jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

EAP-SIM/AKA: Explicitly check for header to include Reserved field

Browse source 
This was previously checked as part of the eap_sim_parse_attr()
processing, but it is easier to review the code if there is an
additional explicit check for confirming that the Reserved field is
present since the pos variable is advanced beyond it.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2015-05-03 11:18:31 +03:00
parent f0174bff85
commit ff4a6d4382
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/eap_peer/eap_aka.c
View file

@ -1296,7 +1296,7 @@ static struct wpabuf * eap_aka_process(struct eap_sm *sm, void *priv,
pos = eap_hdr_validate(EAP_VENDOR_IETF, data->eap_method, reqData, pos = eap_hdr_validate(EAP_VENDOR_IETF, data->eap_method, reqData,
&len); &len);
if (pos == NULL || len < 1) { if (pos == NULL || len < 3) {
ret->ignore = TRUE; ret->ignore = TRUE;
return NULL; return NULL;
} }

2
src/eap_peer/eap_sim.c
View file

@ -1042,7 +1042,7 @@ static struct wpabuf * eap_sim_process(struct eap_sm *sm, void *priv,
} }
pos = eap_hdr_validate(EAP_VENDOR_IETF, EAP_TYPE_SIM, reqData, &len); pos = eap_hdr_validate(EAP_VENDOR_IETF, EAP_TYPE_SIM, reqData, &len);
if (pos == NULL || len < 1) { if (pos == NULL || len < 3) {
ret->ignore = TRUE; ret->ignore = TRUE;
return NULL; return NULL;
} }