From ff4a6d4382d399a6bdfad24d75105b8fc1481387 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sun, 3 May 2015 11:18:31 +0300 Subject: [PATCH] EAP-SIM/AKA: Explicitly check for header to include Reserved field This was previously checked as part of the eap_sim_parse_attr() processing, but it is easier to review the code if there is an additional explicit check for confirming that the Reserved field is present since the pos variable is advanced beyond it. Signed-off-by: Jouni Malinen --- src/eap_peer/eap_aka.c | 2 +- src/eap_peer/eap_sim.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/eap_peer/eap_aka.c b/src/eap_peer/eap_aka.c index 0662ae738..dc9e8cc34 100644 --- a/src/eap_peer/eap_aka.c +++ b/src/eap_peer/eap_aka.c @@ -1296,7 +1296,7 @@ static struct wpabuf * eap_aka_process(struct eap_sm *sm, void *priv, pos = eap_hdr_validate(EAP_VENDOR_IETF, data->eap_method, reqData, &len); - if (pos == NULL || len < 1) { + if (pos == NULL || len < 3) { ret->ignore = TRUE; return NULL; } diff --git a/src/eap_peer/eap_sim.c b/src/eap_peer/eap_sim.c index bd06df78d..99a2816ce 100644 --- a/src/eap_peer/eap_sim.c +++ b/src/eap_peer/eap_sim.c @@ -1042,7 +1042,7 @@ static struct wpabuf * eap_sim_process(struct eap_sm *sm, void *priv, } pos = eap_hdr_validate(EAP_VENDOR_IETF, EAP_TYPE_SIM, reqData, &len); - if (pos == NULL || len < 1) { + if (pos == NULL || len < 3) { ret->ignore = TRUE; return NULL; }