jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

wpa_cli: Fix PING in interactive mode with ifname_prefix

Browse source 
The ifname_prefix string could change during line editing and the
periodic PING command running in the background ended up getting the
latest snapshot of the command line due to the pointer being left to
point to the edit buffer. This resulted in unexpected prefix strings
getting used with the periodic PING command. Fix this by temporarily
clearing the ifname_prefix whenever running such a periodic PING.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2014-09-26 15:23:00 +03:00 committed by Jouni Malinen
parent c53a9bf818
commit fa0e91767d
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
wpa_supplicant/wpa_cli.c
View file

@ -3449,10 +3449,18 @@ static int tokenize_cmd(char *cmd, char *argv[])
static void wpa_cli_ping(void *eloop_ctx, void *timeout_ctx) static void wpa_cli_ping(void *eloop_ctx, void *timeout_ctx)
{ {
if (ctrl_conn && _wpa_ctrl_command(ctrl_conn, "PING", 0)) { if (ctrl_conn) {
printf("Connection to wpa_supplicant lost - trying to " int res;
"reconnect\n"); char *prefix = ifname_prefix;
wpa_cli_close_connection();
ifname_prefix = NULL;
res = _wpa_ctrl_command(ctrl_conn, "PING", 0);
ifname_prefix = prefix;
if (res) {
printf("Connection to wpa_supplicant lost - trying to "
"reconnect\n");
wpa_cli_close_connection();
}
} }
if (!ctrl_conn) if (!ctrl_conn)
wpa_cli_reconnect(); wpa_cli_reconnect();