jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

DPP: Do not continue if public key hash derivation fails

Browse source 
sha256_vector() result was ignored apart from printing out the failure
in the debug log. This is not really a normal case and it is better to
reject the full operation rather than try to continue with an incorrect
public key hash value.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2017-11-29 21:40:31 +02:00 committed by Jouni Malinen
parent 8a37d54ea7
commit f981ce7298
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/common/dpp.c
View file

@ -1352,11 +1352,12 @@ char * dpp_keygen(struct dpp_bootstrap_info *bi, const char *curve,
addr[0] = wpabuf_head(der); addr[0] = wpabuf_head(der);
len = wpabuf_len(der); len = wpabuf_len(der);
res = sha256_vector(1, addr, &len, bi->pubkey_hash); res = sha256_vector(1, addr, &len, bi->pubkey_hash);
if (res < 0) if (res < 0) {
wpa_printf(MSG_DEBUG, "DPP: Failed to hash public key"); wpa_printf(MSG_DEBUG, "DPP: Failed to hash public key");
else goto fail;
wpa_hexdump(MSG_DEBUG, "DPP: Public key hash", bi->pubkey_hash, }
SHA256_MAC_LEN); wpa_hexdump(MSG_DEBUG, "DPP: Public key hash", bi->pubkey_hash,
SHA256_MAC_LEN);
base64 = base64_encode(wpabuf_head(der), wpabuf_len(der), &len); base64 = base64_encode(wpabuf_head(der), wpabuf_len(der), &len);
wpabuf_free(der); wpabuf_free(der);