jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

WMM-AC: Use DEBUG verbosity for ignoring Action frame messages

Browse source 
There is no point in flooding the log with WARNING or ERROR level
messages if WMM-AC related Action frames are ignored in cases where they
were not expected. In addition, WARNING/ERROR should not really be used
in cases an invalid frame is dropped especially if this is not related
to a security setup since external devices could otherwise generate log
entries.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2014-12-05 13:08:29 +02:00 committed by Jouni Malinen
parent 5085ffb8f8
commit f80936094e
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
wpa_supplicant/wmm_ac.c
View file

@ -438,7 +438,7 @@ wmm_ac_process_param_elem(struct wpa_supplicant *wpa_s, const u8 *ies,
} }
if (elems.wmm_len != sizeof(*wmm_params)) { if (elems.wmm_len != sizeof(*wmm_params)) {
wpa_printf(MSG_WARNING, "WMM AC: Invalid WMM ie length"); wpa_printf(MSG_DEBUG, "WMM AC: Invalid WMM ie length");
return NULL; return NULL;
} }
@ -658,7 +658,7 @@ static void wmm_ac_handle_delts(struct wpa_supplicant *wpa_s, const u8 *sa,
wmm_ac_del_ts_idx(wpa_s, ac, idx); wmm_ac_del_ts_idx(wpa_s, ac, idx);
wpa_printf(MSG_INFO, wpa_printf(MSG_DEBUG,
"TS was deleted successfully (tsid=%u address=" MACSTR ")", "TS was deleted successfully (tsid=%u address=" MACSTR ")",
tsid, MAC2STR(sa)); tsid, MAC2STR(sa));
} }
@ -679,7 +679,7 @@ static void wmm_ac_handle_addts_resp(struct wpa_supplicant *wpa_s, const u8 *sa,
/* make sure we have a matching addts request */ /* make sure we have a matching addts request */
if (!req || req->dialog_token != resp_dialog_token) { if (!req || req->dialog_token != resp_dialog_token) {
wpa_printf(MSG_ERROR, wpa_printf(MSG_DEBUG,
"WMM AC: no req with dialog=%u, ignoring frame", "WMM AC: no req with dialog=%u, ignoring frame",
resp_dialog_token); resp_dialog_token);
return; return;
@ -690,7 +690,7 @@ static void wmm_ac_handle_addts_resp(struct wpa_supplicant *wpa_s, const u8 *sa,
tsid != wmm_ac_get_tsid(&req->tspec) || tsid != wmm_ac_get_tsid(&req->tspec) ||
up != wmm_ac_get_user_priority(&req->tspec) || up != wmm_ac_get_user_priority(&req->tspec) ||
dir != wmm_ac_get_direction(&req->tspec)) { dir != wmm_ac_get_direction(&req->tspec)) {
wpa_printf(MSG_ERROR, wpa_printf(MSG_DEBUG,
"WMM AC: ADDTS params do not match, ignoring frame"); "WMM AC: ADDTS params do not match, ignoring frame");
return; return;
} }
@ -698,7 +698,7 @@ static void wmm_ac_handle_addts_resp(struct wpa_supplicant *wpa_s, const u8 *sa,
/* delete pending request */ /* delete pending request */
wmm_ac_del_req(wpa_s, 0); wmm_ac_del_req(wpa_s, 0);
wpa_printf(MSG_INFO, wpa_printf(MSG_DEBUG,
"ADDTS response status=%d tsid=%u up=%u direction=%u", "ADDTS response status=%d tsid=%u up=%u direction=%u",
status_code, tsid, up, dir); status_code, tsid, up, dir);
@ -747,7 +747,7 @@ void wmm_ac_rx_action(struct wpa_supplicant *wpa_s, const u8 *da,
struct wmm_tspec_element *tspec; struct wmm_tspec_element *tspec;
if (wpa_s->wmm_ac_assoc_info == NULL) { if (wpa_s->wmm_ac_assoc_info == NULL) {
wpa_printf(MSG_WARNING, wpa_printf(MSG_DEBUG,
"WMM AC: WMM AC is disabled, ignoring action frame"); "WMM AC: WMM AC is disabled, ignoring action frame");
return; return;
} }
@ -756,7 +756,7 @@ void wmm_ac_rx_action(struct wpa_supplicant *wpa_s, const u8 *da,
if (action != WMM_ACTION_CODE_ADDTS_RESP && if (action != WMM_ACTION_CODE_ADDTS_RESP &&
action != WMM_ACTION_CODE_DELTS) { action != WMM_ACTION_CODE_DELTS) {
wpa_printf(MSG_WARNING, wpa_printf(MSG_DEBUG,
"WMM AC: Unknown action (%d), ignoring action frame", "WMM AC: Unknown action (%d), ignoring action frame",
action); action);
return; return;