jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add a workaround to clanc static analyzer warning

Browse source 
dl_list_del() followed by dl_list_add() seemed to confuse clang static
analyzer somehow, so explicitly check for the prev pointer to be
non-NULL to avoid an incorrect warning.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2014-10-11 17:18:02 +03:00
parent 3e9fa3be62
commit f4452cc2b1
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/rsn_supp/preauth.c
View file

@ -391,6 +391,18 @@ void pmksa_candidate_add(struct wpa_sm *sm, const u8 *bssid,
dl_list_for_each(pos, &sm->pmksa_candidates, dl_list_for_each(pos, &sm->pmksa_candidates,
struct rsn_pmksa_candidate, list) { struct rsn_pmksa_candidate, list) {
if (cand->priority <= pos->priority) { if (cand->priority <= pos->priority) {
if (!pos->list.prev) {
/*
* This cannot really happen in pracrice since
* pos was fetched from the list and the prev
* pointer must be set. It looks like clang
* static analyzer gets confused with the
* dl_list_del(&cand->list) call above and ends
* up assuming pos->list.prev could be NULL.
*/
os_free(cand);
return;
}
dl_list_add(pos->list.prev, &cand->list); dl_list_add(pos->list.prev, &cand->list);
cand = NULL; cand = NULL;
break; break;