From f1c4dbf5cd2250e1e198c174eb0475d38b6b8aef Mon Sep 17 00:00:00 2001 From: Ilan Peer Date: Thu, 27 Mar 2014 08:58:33 +0200 Subject: [PATCH] wpa_supplicant: Remove pending sme-connect radio work If a new connection is attempted while there is a pending sme-connection radio work, cancel the pending radio work and continue with the new connection attempt. This is preferable over rejecting the new work and continuing with the pending one, as it is possible that the previous work is no longer valid. Signed-off-by: Ilan Peer --- wpa_supplicant/sme.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/wpa_supplicant/sme.c b/wpa_supplicant/sme.c index a860afb86..2538ba0ce 100644 --- a/wpa_supplicant/sme.c +++ b/wpa_supplicant/sme.c @@ -477,8 +477,14 @@ void sme_authenticate(struct wpa_supplicant *wpa_s, } if (radio_work_pending(wpa_s, "sme-connect")) { - wpa_dbg(wpa_s, MSG_DEBUG, "SME: Reject sme_authenticate() call since pending work exist"); - return; + /* + * The previous sme-connect work might no longer be valid due to + * the fact that the BSS list was updated. In addition, it makes + * sense to adhere to the 'newer' decision. + */ + wpa_dbg(wpa_s, MSG_DEBUG, + "SME: Remove previous pending sme-connect"); + radio_remove_works(wpa_s, "sme-connect", 0); } cwork = os_zalloc(sizeof(*cwork));