jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Set Acct-Session-Id from os_get_random() instead of os_get_time()

Browse source 
So that systems with bad clocks will send random session IDs,
instead of always ones starting at the same second.

If os_get_random() isn't available, use os_get_time(). But also
mix in now.tv_usec, so that the accounting session ID is more
likely to be globally and temporally unique.

Signed-off-by: Alan DeKok <aland@freeradius.org>
This commit is contained in:
Alan T. DeKok 2015-06-04 16:53:06 -04:00 committed by Jouni Malinen
parent 92f190a0ac
commit f13e815491
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/ap/accounting.c
View file

@ -459,10 +459,14 @@ int accounting_init(struct hostapd_data *hapd)
{ {
struct os_time now; struct os_time now;
/* Acct-Session-Id should be unique over reboots. If reliable clock is /* Acct-Session-Id should be unique over reboots. Using a random number
* not available, this could be replaced with reboot counter, etc. */ * is preferred. If that is not available, take the current time. Mix
* in microseconds to make this more likely to be unique. */
os_get_time(&now); os_get_time(&now);
hapd->acct_session_id_hi = now.sec; if (os_get_random((u8 *) &hapd->acct_session_id_hi,
sizeof(hapd->acct_session_id_hi)) < 0)
hapd->acct_session_id_hi = now.sec;
hapd->acct_session_id_hi ^= now.usec;
if (radius_client_register(hapd->radius, RADIUS_ACCT, if (radius_client_register(hapd->radius, RADIUS_ACCT,
accounting_receive, hapd)) accounting_receive, hapd))