jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

D-Bus (old): Fix message handler error paths

Browse source 
The error reply needs to be sent out as a response. The "out" label was
in incorrect place to allow that to happen; instead, it ended up leaking
memory for the generated reply message.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2015-01-06 13:22:06 +02:00
parent a2af1c70c5
commit f0614bc6c6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
wpa_supplicant/dbus/dbus_old.c
View file

@ -292,13 +292,13 @@ static DBusHandlerResult wpas_iface_message_handler(DBusConnection *connection,
} }
/* If the message was handled, send back the reply */ /* If the message was handled, send back the reply */
out:
if (reply) { if (reply) {
if (!dbus_message_get_no_reply(message)) if (!dbus_message_get_no_reply(message))
dbus_connection_send(connection, reply, NULL); dbus_connection_send(connection, reply, NULL);
dbus_message_unref(reply); dbus_message_unref(reply);
} }
out:
os_free(iface_obj_path); os_free(iface_obj_path);
os_free(network); os_free(network);
os_free(bssid); os_free(bssid);