jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

D-Bus: Fix Introspect() in case of os_strdup() failure

Browse source 
add_interface() did not check for os_strdup() return value and could end
up dereferencing a NULL pointer if memory allocation failed.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2015-01-06 15:55:51 +02:00
parent 68a866974b
commit dacf605812
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
wpa_supplicant/dbus/dbus_new_introspect.c
View file

@ -37,14 +37,16 @@ static struct interfaces * add_interface(struct dl_list *list,
iface = os_zalloc(sizeof(struct interfaces)); iface = os_zalloc(sizeof(struct interfaces));
if (!iface) if (!iface)
return NULL; return NULL;
iface->dbus_interface = os_strdup(dbus_interface);
iface->xml = wpabuf_alloc(6000); iface->xml = wpabuf_alloc(6000);
if (iface->xml == NULL) { if (iface->dbus_interface == NULL || iface->xml == NULL) {
os_free(iface->dbus_interface);
wpabuf_free(iface->xml);
os_free(iface); os_free(iface);
return NULL; return NULL;
} }
wpabuf_printf(iface->xml, "<interface name=\"%s\">", dbus_interface); wpabuf_printf(iface->xml, "<interface name=\"%s\">", dbus_interface);
dl_list_add_tail(list, &iface->list); dl_list_add_tail(list, &iface->list);
iface->dbus_interface = os_strdup(dbus_interface);
return iface; return iface;
} }