D-Bus: Add association response status code property for failure cases

(Re)Association Response frame with status code other than 0 is now
notified over DBUS as a part of PropertiesChanged signal. This can be
used by application in case AP is denying association with status code
17 (band steering) so that it does not interfere in the BSSID selection
logic of wpa_supplicant.

Signed-off-by: Naveen Singh <nasingh@google.com>
This commit is contained in:
Naveen Singh 2016-03-03 10:48:09 -08:00 committed by Jouni Malinen
parent 2940bf669a
commit c7fb678f31
9 changed files with 52 additions and 0 deletions

View file

@ -735,6 +735,11 @@ fi.w1.wpa_supplicant1.CreateInterface.
<p>The most recent IEEE 802.11 reason code for disconnect. Negative value indicates locally generated disconnection.</p> <p>The most recent IEEE 802.11 reason code for disconnect. Negative value indicates locally generated disconnection.</p>
</li> </li>
<li>
<h3>AssocStatusCode - i - (read)</h3>
<p>The most recent IEEE 802.11 status code for association rejection.</p>
</li>
<li> <li>
<h3>EapolVersion - s - (read/write)</h3> <h3>EapolVersion - s - (read/write)</h3>
<p>IEEE 802.1X/EAPOL version number</p> <p>IEEE 802.1X/EAPOL version number</p>

View file

@ -2001,6 +2001,10 @@ void wpas_dbus_signal_prop_changed(struct wpa_supplicant *wpa_s,
prop = "DisconnectReason"; prop = "DisconnectReason";
flush = TRUE; flush = TRUE;
break; break;
case WPAS_DBUS_PROP_ASSOC_STATUS_CODE:
prop = "AssocStatusCode";
flush = TRUE;
break;
default: default:
wpa_printf(MSG_ERROR, "dbus: %s: Unknown Property value %d", wpa_printf(MSG_ERROR, "dbus: %s: Unknown Property value %d",
__func__, property); __func__, property);
@ -3255,6 +3259,11 @@ static const struct wpa_dbus_property_desc wpas_dbus_interface_properties[] = {
NULL, NULL,
NULL NULL
}, },
{ "AssocStatusCode", WPAS_DBUS_NEW_IFACE_INTERFACE, "i",
wpas_dbus_getter_assoc_status_code,
NULL,
NULL
},
{ NULL, NULL, NULL, NULL, NULL, NULL } { NULL, NULL, NULL, NULL, NULL, NULL }
}; };

View file

@ -29,6 +29,7 @@ enum wpas_dbus_prop {
WPAS_DBUS_PROP_CURRENT_AUTH_MODE, WPAS_DBUS_PROP_CURRENT_AUTH_MODE,
WPAS_DBUS_PROP_BSSS, WPAS_DBUS_PROP_BSSS,
WPAS_DBUS_PROP_DISCONNECT_REASON, WPAS_DBUS_PROP_DISCONNECT_REASON,
WPAS_DBUS_PROP_ASSOC_STATUS_CODE,
}; };
enum wpas_dbus_bss_prop { enum wpas_dbus_bss_prop {

View file

@ -2857,6 +2857,27 @@ dbus_bool_t wpas_dbus_getter_disconnect_reason(
} }
/**
* wpas_dbus_getter_assoc_status_code - Get most recent failed assoc status code
* @iter: Pointer to incoming dbus message iter
* @error: Location to store error on failure
* @user_data: Function specific data
* Returns: TRUE on success, FALSE on failure
*
* Getter for "AssocStatusCode" property.
*/
dbus_bool_t wpas_dbus_getter_assoc_status_code(
const struct wpa_dbus_property_desc *property_desc,
DBusMessageIter *iter, DBusError *error, void *user_data)
{
struct wpa_supplicant *wpa_s = user_data;
dbus_int32_t status_code = wpa_s->assoc_status_code;
return wpas_dbus_simple_property_getter(iter, DBUS_TYPE_INT32,
&status_code, error);
}
/** /**
* wpas_dbus_getter_bss_expire_age - Get BSS entry expiration age * wpas_dbus_getter_bss_expire_age - Get BSS entry expiration age
* @iter: Pointer to incoming dbus message iter * @iter: Pointer to incoming dbus message iter

View file

@ -138,6 +138,7 @@ DECLARE_ACCESSOR(wpas_dbus_getter_fast_reauth);
DECLARE_ACCESSOR(wpas_dbus_setter_fast_reauth); DECLARE_ACCESSOR(wpas_dbus_setter_fast_reauth);
DECLARE_ACCESSOR(wpas_dbus_getter_disconnect_reason); DECLARE_ACCESSOR(wpas_dbus_getter_disconnect_reason);
DECLARE_ACCESSOR(wpas_dbus_getter_disassociate_reason); DECLARE_ACCESSOR(wpas_dbus_getter_disassociate_reason);
DECLARE_ACCESSOR(wpas_dbus_getter_assoc_status_code);
DECLARE_ACCESSOR(wpas_dbus_getter_bss_expire_age); DECLARE_ACCESSOR(wpas_dbus_getter_bss_expire_age);
DECLARE_ACCESSOR(wpas_dbus_setter_bss_expire_age); DECLARE_ACCESSOR(wpas_dbus_setter_bss_expire_age);
DECLARE_ACCESSOR(wpas_dbus_getter_bss_expire_count); DECLARE_ACCESSOR(wpas_dbus_getter_bss_expire_count);

View file

@ -3501,6 +3501,8 @@ void wpa_supplicant_event(void *ctx, enum wpa_event_type event,
wpa_msg(wpa_s, MSG_INFO, WPA_EVENT_ASSOC_REJECT wpa_msg(wpa_s, MSG_INFO, WPA_EVENT_ASSOC_REJECT
"status_code=%u", "status_code=%u",
data->assoc_reject.status_code); data->assoc_reject.status_code);
wpa_s->assoc_status_code = data->assoc_reject.status_code;
wpas_notify_assoc_status_code(wpa_s);
if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_SME) if (wpa_s->drv_flags & WPA_DRIVER_FLAGS_SME)
sme_event_assoc_reject(wpa_s, data); sme_event_assoc_reject(wpa_s, data);
else { else {

View file

@ -128,6 +128,15 @@ void wpas_notify_disconnect_reason(struct wpa_supplicant *wpa_s)
} }
void wpas_notify_assoc_status_code(struct wpa_supplicant *wpa_s)
{
if (wpa_s->p2p_mgmt)
return;
wpas_dbus_signal_prop_changed(wpa_s, WPAS_DBUS_PROP_ASSOC_STATUS_CODE);
}
void wpas_notify_network_changed(struct wpa_supplicant *wpa_s) void wpas_notify_network_changed(struct wpa_supplicant *wpa_s)
{ {
if (wpa_s->p2p_mgmt) if (wpa_s->p2p_mgmt)

View file

@ -23,6 +23,7 @@ void wpas_notify_state_changed(struct wpa_supplicant *wpa_s,
enum wpa_states new_state, enum wpa_states new_state,
enum wpa_states old_state); enum wpa_states old_state);
void wpas_notify_disconnect_reason(struct wpa_supplicant *wpa_s); void wpas_notify_disconnect_reason(struct wpa_supplicant *wpa_s);
void wpas_notify_assoc_status_code(struct wpa_supplicant *wpa_s);
void wpas_notify_network_changed(struct wpa_supplicant *wpa_s); void wpas_notify_network_changed(struct wpa_supplicant *wpa_s);
void wpas_notify_ap_scan_changed(struct wpa_supplicant *wpa_s); void wpas_notify_ap_scan_changed(struct wpa_supplicant *wpa_s);
void wpas_notify_bssid_changed(struct wpa_supplicant *wpa_s); void wpas_notify_bssid_changed(struct wpa_supplicant *wpa_s);

View file

@ -950,6 +950,9 @@ struct wpa_supplicant {
/* WLAN_REASON_* reason codes. Negative if locally generated. */ /* WLAN_REASON_* reason codes. Negative if locally generated. */
int disconnect_reason; int disconnect_reason;
/* WLAN_STATUS_* status codes from (Re)Association Response frame. */
u16 assoc_status_code;
struct ext_password_data *ext_pw; struct ext_password_data *ext_pw;
struct wpabuf *last_gas_resp, *prev_gas_resp; struct wpabuf *last_gas_resp, *prev_gas_resp;