From c6231b5e1ead720f8c597686260383fc9c351c68 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Mon, 28 Dec 2015 18:15:18 +0200 Subject: [PATCH] TLS: Remove storing of never-read value While this could in theory be claimed to be ready for something to be added to read a field following the server_write_IV, it does not look likely that such a use case would show up. As such, just remove the unused incrementing of pos at the end of the function to get rid of a useless static analyzer complaint. Signed-off-by: Jouni Malinen --- src/tls/tlsv1_client.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tls/tlsv1_client.c b/src/tls/tlsv1_client.c index cc404c156..9bc0d211f 100644 --- a/src/tls/tlsv1_client.c +++ b/src/tls/tlsv1_client.c @@ -111,7 +111,6 @@ int tls_derive_keys(struct tlsv1_client *conn, pos += conn->rl.iv_size; /* server_write_IV */ os_memcpy(conn->rl.read_iv, pos, conn->rl.iv_size); - pos += conn->rl.iv_size; } else { /* * Use IV field to set the mask value for TLS v1.1. A fixed