jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

EAP-FAST: Make PAC file A_ID parser easier to analyze

Browse source 
Some static analyzers seem to have issues with "pos + len > end"
validation (CID 62875), so convert this to "len > end - pos" to make it
more obvious that len is validated against its bounds.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2014-11-23 20:36:17 +02:00
parent 364182a80f
commit c4de71cec5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/eap_peer/eap_fast_pac.c
View file

@ -714,7 +714,7 @@ static void eap_fast_pac_get_a_id(struct eap_fast_pac *pac)
pos += 2;
len = WPA_GET_BE16(pos);
pos += 2;
if (pos + len > end)
if (len > (unsigned int) (end - pos))
break;
if (type == PAC_TYPE_A_ID) {