jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

ERP server: Make erp_send_finish_reauth() easier for static analyzers

Browse source 
The flags argument is used to indicate a failure case (0x80) which
allows erp == NULL. This may be a bit too difficult combination for
static analyzers to understand, so add an explicit check for !erp as
another condition for returning from the function before the erp pointer
gets dereferenced without checking it.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2015-06-23 18:25:35 +03:00
parent 6ce1bea1ff
commit c3c5b5fe92
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/eap_server/eap_server.c
View file

@ -745,7 +745,7 @@ static void erp_send_finish_reauth(struct eap_sm *sm,
wpabuf_free(sm->lastReqData); wpabuf_free(sm->lastReqData);
sm->lastReqData = NULL; sm->lastReqData = NULL;
if (flags & 0x80) { if ((flags & 0x80) || !erp) {
sm->eap_if.eapFail = TRUE; sm->eap_if.eapFail = TRUE;
wpa_msg(sm->msg_ctx, MSG_INFO, WPA_EVENT_EAP_FAILURE wpa_msg(sm->msg_ctx, MSG_INFO, WPA_EVENT_EAP_FAILURE
MACSTR, MAC2STR(sm->peer_addr)); MACSTR, MAC2STR(sm->peer_addr));