jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Do not check unsigned size is less than zero

Browse source 
The variables here are unsigned and as such, cannot have a negative
value. Use == 0 instead of <= 0 to make this cleaner.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2015-06-23 21:12:29 +03:00
parent fdc5608c12
commit c1a14ef42f
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
wpa_supplicant/dbus/dbus_new_handlers.c
View file

@ -214,7 +214,7 @@ dbus_bool_t set_network_properties(struct wpa_supplicant *wpa_s,
} else if (entry.type == DBUS_TYPE_STRING) { } else if (entry.type == DBUS_TYPE_STRING) {
if (should_quote_opt(entry.key)) { if (should_quote_opt(entry.key)) {
size = os_strlen(entry.str_value); size = os_strlen(entry.str_value);
if (size <= 0) if (size == 0)
goto error; goto error;
size += 3; size += 3;

2
wpa_supplicant/dbus/dbus_old_handlers.c
View file

@ -884,7 +884,7 @@ DBusMessage * wpas_dbus_iface_set_network(DBusMessage *message,
if (should_quote_opt(entry.key)) { if (should_quote_opt(entry.key)) {
size = os_strlen(entry.str_value); size = os_strlen(entry.str_value);
/* Zero-length option check */ /* Zero-length option check */
if (size <= 0) if (size == 0)
goto error; goto error;
size += 3; /* For quotes and terminator */ size += 3; /* For quotes and terminator */
value = os_zalloc(size); value = os_zalloc(size);

2
wpa_supplicant/events.c
View file

@ -1685,7 +1685,7 @@ int wpa_supplicant_fast_associate(struct wpa_supplicant *wpa_s)
#else /* CONFIG_NO_SCAN_PROCESSING */ #else /* CONFIG_NO_SCAN_PROCESSING */
struct os_reltime now; struct os_reltime now;
if (wpa_s->last_scan_res_used <= 0) if (wpa_s->last_scan_res_used == 0)
return -1; return -1;
os_get_reltime(&now); os_get_reltime(&now);