jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

wpa_supplicant: Remove unfeasible conditions in config parsing

Browse source 
pos can't be NULL in wpa_global_config_parse_str(), so there is no point
checking this, especially when pos was already dereferenced earlier.
Remove the redundant conditions.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
This commit is contained in:
Andrei Otcheretianski 2020-10-19 11:06:29 +03:00 committed by Jouni Malinen
parent ff7e0c1cf7
commit b4c7114cf5
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
wpa_supplicant/config.c
View file

@ -4469,9 +4469,7 @@ static int wpa_global_config_parse_str(const struct global_parse_data *data,
prev_len = 0; prev_len = 0;
/* No change to the previously configured value */ /* No change to the previously configured value */
if ((!(*dst) && !pos) || if (*dst && prev_len == len && os_memcmp(*dst, pos, len) == 0)
(*dst && pos && prev_len == len &&
os_memcmp(*dst, pos, len) == 0))
return 1; return 1;
tmp = os_strdup(pos); tmp = os_strdup(pos);