From b375b04b673a7762a125dca5a8e9e2ba0c6b363c Mon Sep 17 00:00:00 2001 From: Markus Theil Date: Mon, 28 May 2018 22:26:46 +0200 Subject: [PATCH] WNM: Fix time_zone advertisement without time_zone configuration If time_advertisement=2 is included in hostapd configuration, but time_zone is unset, the previous implementation tried to write the Time Zone element into management frames. This resulted in segmentation fault when trying to dereference a NULL pointer. Fix that by skipping addition of this element when time_zone parameter is not set. Signed-off-by: Markus Theil --- src/ap/ieee802_11_shared.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ap/ieee802_11_shared.c b/src/ap/ieee802_11_shared.c index d3733c8eb..a3f860992 100644 --- a/src/ap/ieee802_11_shared.c +++ b/src/ap/ieee802_11_shared.c @@ -446,7 +446,7 @@ u8 * hostapd_eid_time_zone(struct hostapd_data *hapd, u8 *eid) { size_t len; - if (hapd->conf->time_advertisement != 2) + if (hapd->conf->time_advertisement != 2 || !hapd->conf->time_zone) return eid; len = os_strlen(hapd->conf->time_zone);