jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove unneeded hostapd_wmm_sta_config()

Browse source 
The WMM STA flag is already taken care of by handle_assoc_cb() and there
is no point trying to do this unless hostapd is taking care MLME
processing, so no need to call this from drv_callbacks.c.
This commit is contained in:
Jouni Malinen 2009-12-13 11:14:21 +02:00
parent 60c8cfb4fb
commit a34325dde9
3 changed files with 0 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hostapd/drv_callbacks.c
View file

@ -106,8 +106,6 @@ void hostapd_new_assoc_sta(struct hostapd_data *hapd, struct sta_info *sta,
if (!hapd->conf->ieee802_1x && !hapd->conf->wpa)
accounting_sta_start(hapd, sta);
hostapd_wmm_sta_config(hapd, sta);
/* Start IEEE 802.1X authentication process for new stations */
ieee802_1x_new_station(hapd, sta);
if (reassoc) {

17
hostapd/wme.c
View file

@ -119,23 +119,6 @@ int hostapd_eid_wmm_valid(struct hostapd_data *hapd, const u8 *eid, size_t len)
}
/* This function is called when a station sends an ACK frame for an AssocResp
* frame (status=success) and the matching AssocReq contained a WMM element.
*/
int hostapd_wmm_sta_config(struct hostapd_data *hapd, struct sta_info *sta)
{
/* update kernel STA data for WMM related items (WLAN_STA_WPA flag) */
if (sta->flags & WLAN_STA_WMM)
hostapd_sta_set_flags(hapd, sta->addr, sta->flags,
WLAN_STA_WMM, ~0);
else
hostapd_sta_set_flags(hapd, sta->addr, sta->flags,
0, ~WLAN_STA_WMM);
return 0;
}
static void wmm_send_action(struct hostapd_data *hapd, const u8 *addr,
const struct wmm_tspec_element *tspec,
u8 action_code, u8 dialogue_token, u8 status_code)

9
hostapd/wme.h
View file

@ -21,15 +21,6 @@ struct ieee80211_mgmt;
u8 * hostapd_eid_wmm(struct hostapd_data *hapd, u8 *eid);
int hostapd_eid_wmm_valid(struct hostapd_data *hapd, const u8 *eid,
size_t len);
#ifdef NEED_AP_MLME
int hostapd_wmm_sta_config(struct hostapd_data *hapd, struct sta_info *sta);
#else /* NEED_AP_MLME */
static inline int hostapd_wmm_sta_config(struct hostapd_data *hapd,
struct sta_info *sta)
{
return 0;
}
#endif /* NEED_AP_MLME */
void hostapd_wmm_action(struct hostapd_data *hapd, struct ieee80211_mgmt *mgmt,
size_t len);
int wmm_process_tspec(struct wmm_tspec_element *tspec);