From 9c06eda01ce6f0e9bdaa86a1c017f23212435b8a Mon Sep 17 00:00:00 2001 From: Masashi Honma Date: Thu, 31 Jan 2019 17:15:41 +0900 Subject: [PATCH] tests: Use python3 compatible libraries This patch is made by using 2to3 command with some modifications. $ find . -name *.py | xargs 2to3 -f imports -w -n Signed-off-by: Masashi Honma --- tests/hwsim/p2p_utils.py | 9 ++- tests/hwsim/test_ap_eap.py | 5 +- tests/hwsim/test_ap_wps.py | 157 ++++++++++++++++++++----------------- 3 files changed, 94 insertions(+), 77 deletions(-) diff --git a/tests/hwsim/p2p_utils.py b/tests/hwsim/p2p_utils.py index 1a4646dc7..3abc00a62 100644 --- a/tests/hwsim/p2p_utils.py +++ b/tests/hwsim/p2p_utils.py @@ -8,7 +8,10 @@ import logging logger = logging.getLogger() import threading import time -import Queue +try: + from Queue import Queue +except ImportError: + from queue import Queue import hwsim_utils @@ -238,7 +241,7 @@ def go_neg_pin(i_dev, r_dev, i_intent=None, r_intent=None, i_method='enter', r_m pin = r_dev.wps_read_pin() logger.info("Start GO negotiation " + i_dev.ifname + " -> " + r_dev.ifname) r_dev.dump_monitor() - res = Queue.Queue() + res = Queue() t = threading.Thread(target=go_neg_init, args=(i_dev, r_dev, pin, i_method, i_intent, res)) t.start() logger.debug("Wait for GO Negotiation Request on r_dev") @@ -318,7 +321,7 @@ def go_neg_pbc(i_dev, r_dev, i_intent=None, r_intent=None, i_freq=None, r_freq=N i_dev.p2p_find(social=True) logger.info("Start GO negotiation " + i_dev.ifname + " -> " + r_dev.ifname) r_dev.dump_monitor() - res = Queue.Queue() + res = Queue() t = threading.Thread(target=go_neg_init_pbc, args=(i_dev, r_dev, i_intent, res, i_freq, provdisc)) t.start() logger.debug("Wait for GO Negotiation Request on r_dev") diff --git a/tests/hwsim/test_ap_eap.py b/tests/hwsim/test_ap_eap.py index f39b924b5..d0826c210 100644 --- a/tests/hwsim/test_ap_eap.py +++ b/tests/hwsim/test_ap_eap.py @@ -14,7 +14,10 @@ logger = logging.getLogger() import os import signal import socket -import SocketServer +try: + import SocketServer +except ImportError: + import socketserver as SocketServer import struct import tempfile diff --git a/tests/hwsim/test_ap_wps.py b/tests/hwsim/test_ap_wps.py index fe069d396..ab555aff5 100644 --- a/tests/hwsim/test_ap_wps.py +++ b/tests/hwsim/test_ap_wps.py @@ -19,12 +19,22 @@ logger = logging.getLogger() import re import socket import struct -import httplib -import urlparse +try: + from http.client import HTTPConnection + from urllib.request import urlopen + from urllib.parse import urlparse, urljoin + from urllib.error import HTTPError + from io import StringIO + from socketserver import StreamRequestHandler, TCPServer +except ImportError: + from httplib import HTTPConnection + from urllib import urlopen + from urlparse import urlparse, urljoin + from urllib2 import build_opener, ProxyHandler, HTTPError + from StringIO import StringIO + from SocketServer import StreamRequestHandler, TCPServer import urllib import xml.etree.ElementTree as ET -import StringIO -import SocketServer import hwsim_utils import hostapd @@ -2351,13 +2361,13 @@ def test_ap_wps_pbc_timeout(dev, apdev, params): location = ssdp_get_location(ap_uuid) urls = upnp_get_urls(location) - eventurl = urlparse.urlparse(urls['event_sub_url']) - ctrlurl = urlparse.urlparse(urls['control_url']) + eventurl = urlparse(urls['event_sub_url']) + ctrlurl = urlparse(urls['control_url']) - url = urlparse.urlparse(location) - conn = httplib.HTTPConnection(url.netloc) + url = urlparse(location) + conn = HTTPConnection(url.netloc) - class WPSERHTTPServer(SocketServer.StreamRequestHandler): + class WPSERHTTPServer(StreamRequestHandler): def handle(self): data = self.rfile.readline().strip() logger.debug(data) @@ -2758,15 +2768,17 @@ def ssdp_get_location(uuid): return location def upnp_get_urls(location): - conn = urllib.urlopen(location, proxies={}) + conn = urlopen(location, proxies={}) tree = ET.parse(conn) root = tree.getroot() urn = '{urn:schemas-upnp-org:device-1-0}' service = root.find("./" + urn + "device/" + urn + "serviceList/" + urn + "service") res = {} - res['scpd_url'] = urlparse.urljoin(location, service.find(urn + 'SCPDURL').text) - res['control_url'] = urlparse.urljoin(location, service.find(urn + 'controlURL').text) - res['event_sub_url'] = urlparse.urljoin(location, service.find(urn + 'eventSubURL').text) + res['scpd_url'] = urljoin(location, service.find(urn + 'SCPDURL').text) + res['control_url'] = urljoin(location, + service.find(urn + 'controlURL').text) + res['event_sub_url'] = urljoin(location, + service.find(urn + 'eventSubURL').text) return res def upnp_soap_action(conn, path, action, include_soap_action=True, @@ -2791,7 +2803,7 @@ def upnp_soap_action(conn, path, action, include_soap_action=True, msg = ET.SubElement(act, "NewWLANEventMAC") msg.text = neweventmac tree = ET.ElementTree(root) - soap = StringIO.StringIO() + soap = StringIO() tree.write(soap, xml_declaration=True, encoding='utf-8') headers = { "Content-type": 'text/xml; charset="utf-8"' } @@ -2810,16 +2822,15 @@ def test_ap_wps_upnp(dev, apdev): location = ssdp_get_location(ap_uuid) urls = upnp_get_urls(location) - conn = urllib.urlopen(urls['scpd_url'], proxies={}) + conn = urlopen(urls['scpd_url'], proxies={}) scpd = conn.read() - conn = urllib.urlopen(urlparse.urljoin(location, "unknown.html"), - proxies={}) + conn = urlopen(urljoin(location, "unknown.html"), proxies={}) if conn.getcode() != 404: raise Exception("Unexpected HTTP response to GET unknown URL") - url = urlparse.urlparse(location) - conn = httplib.HTTPConnection(url.netloc) + url = urlparse(location) + conn = HTTPConnection(url.netloc) #conn.set_debuglevel(1) headers = { "Content-type": 'text/xml; charset="utf-8"', "SOAPAction": '"urn:schemas-wifialliance-org:service:WFAWLANConfig:1#GetDeviceInfo"' } @@ -2835,7 +2846,7 @@ def test_ap_wps_upnp(dev, apdev): headers = { "Content-type": 'text/xml; charset="utf-8"', "SOAPAction": '"urn:some-unknown-action#GetDeviceInfo"' } - ctrlurl = urlparse.urlparse(urls['control_url']) + ctrlurl = urlparse(urls['control_url']) conn.request("POST", ctrlurl.path, "\r\n\r\n", headers) resp = conn.getresponse() if resp.status != 401: @@ -2892,10 +2903,10 @@ def test_ap_wps_upnp_subscribe(dev, apdev): location = ssdp_get_location(ap_uuid) urls = upnp_get_urls(location) - eventurl = urlparse.urlparse(urls['event_sub_url']) + eventurl = urlparse(urls['event_sub_url']) - url = urlparse.urlparse(location) - conn = httplib.HTTPConnection(url.netloc) + url = urlparse(location) + conn = HTTPConnection(url.netloc) #conn.set_debuglevel(1) headers = { "callback": '', "timeout": "Second-1234" } @@ -3241,9 +3252,9 @@ def test_ap_wps_upnp_subscribe_events(dev, apdev): location = ssdp_get_location(ap_uuid) urls = upnp_get_urls(location) - eventurl = urlparse.urlparse(urls['event_sub_url']) + eventurl = urlparse(urls['event_sub_url']) - class WPSERHTTPServer(SocketServer.StreamRequestHandler): + class WPSERHTTPServer(StreamRequestHandler): def handle(self): data = self.rfile.readline().strip() logger.debug(data) @@ -3252,8 +3263,8 @@ def test_ap_wps_upnp_subscribe_events(dev, apdev): server = MyTCPServer(("127.0.0.1", 12345), WPSERHTTPServer) server.timeout = 1 - url = urlparse.urlparse(location) - conn = httplib.HTTPConnection(url.netloc) + url = urlparse(location) + conn = HTTPConnection(url.netloc) headers = { "callback": '', "NT": "upnp:event", @@ -3308,8 +3319,8 @@ def test_ap_wps_upnp_http_proto(dev, apdev): location = ssdp_get_location(ap_uuid) - url = urlparse.urlparse(location) - conn = httplib.HTTPConnection(url.netloc, timeout=0.2) + url = urlparse(location) + conn = HTTPConnection(url.netloc, timeout=0.2) #conn.set_debuglevel(1) conn.request("HEAD", "hello") @@ -3407,8 +3418,8 @@ def test_ap_wps_upnp_http_proto_chunked(dev, apdev): location = ssdp_get_location(ap_uuid) - url = urlparse.urlparse(location) - conn = httplib.HTTPConnection(url.netloc) + url = urlparse(location) + conn = HTTPConnection(url.netloc) #conn.set_debuglevel(1) headers = { "Transfer-Encoding": 'chunked' } @@ -4079,7 +4090,7 @@ def gen_wps_event(sid='uuid:7eb3342a-8a5f-47fe-a585-0785bfec6d8a'): 'Date: Sat, 15 Aug 2015 18:55:08 GMT\r\n\r\n' return hdr + payload -class WPSAPHTTPServer(SocketServer.StreamRequestHandler): +class WPSAPHTTPServer(StreamRequestHandler): def handle(self): data = self.rfile.readline().strip() logger.info("HTTP server received: " + data) @@ -4113,10 +4124,10 @@ class WPSAPHTTPServer(SocketServer.StreamRequestHandler): def handle_others(self, data): logger.info("Ignore HTTP request: " + data) -class MyTCPServer(SocketServer.TCPServer): +class MyTCPServer(TCPServer): def __init__(self, addr, handler): self.allow_reuse_address = True - SocketServer.TCPServer.__init__(self, addr, handler) + TCPServer.__init__(self, addr, handler) def wps_er_start(dev, http_server, max_age=1, wait_m_search=False, location_url=None): @@ -4184,7 +4195,7 @@ def run_wps_er_proto_test(dev, handler, no_event_url=False, location_url=None): dev.request("WPS_ER_STOP") def send_wlanevent(url, uuid, data, no_response=False): - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) payload = ''' 1 @@ -4239,8 +4250,8 @@ def _test_ap_wps_er_http_proto(dev, apdev): sock.close() logger.info("Valid Probe Request notification") - url = urlparse.urlparse(wps_event_url) - conn = httplib.HTTPConnection(url.netloc) + url = urlparse(wps_event_url) + conn = HTTPConnection(url.netloc) payload = ''' 1 @@ -4270,32 +4281,32 @@ RGV2aWNlIEEQSQAGADcqAAEg raise Exception("No Enrollee UUID match") logger.info("Incorrect event URL AP id") - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("NOTIFY", url.path + '123', payload, headers) resp = conn.getresponse() if resp.status != 404: raise Exception("Unexpected HTTP response: %d" % resp.status) logger.info("Missing AP id") - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("NOTIFY", '/event/' + url.path.split('/')[2], payload, headers) time.sleep(0.1) logger.info("Incorrect event URL event id") - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("NOTIFY", '/event/123456789/123', payload, headers) time.sleep(0.1) logger.info("Incorrect event URL prefix") - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("NOTIFY", '/foobar/123456789/123', payload, headers) resp = conn.getresponse() if resp.status != 404: raise Exception("Unexpected HTTP response: %d" % resp.status) logger.info("Unsupported request") - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("FOOBAR", '/foobar/123456789/123', payload, headers) resp = conn.getresponse() if resp.status != 501: @@ -4303,7 +4314,7 @@ RGV2aWNlIEEQSQAGADcqAAEg logger.info("Unsupported request and OOM") with alloc_fail(dev[0], 1, "wps_er_http_req"): - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("FOOBAR", '/foobar/123456789/123', payload, headers) time.sleep(0.5) @@ -4543,7 +4554,7 @@ RGV2aWNlIEEQSQAGADcqAAEg pass sock.close() - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) payload = '', "NT": "upnp:event", "timeout": "Second-1234" } @@ -9381,7 +9392,7 @@ def test_ap_wps_upnp_web_oom(dev, apdev, params): pass with alloc_fail(hapd, 1, "dup_binstr;web_connection_parse_subscribe"): - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) headers = { "callback": '', "NT": "upnp:event", "timeout": "Second-1234" } @@ -9391,7 +9402,7 @@ def test_ap_wps_upnp_web_oom(dev, apdev, params): raise Exception("Unexpected HTTP response: %d" % resp.status) with alloc_fail(hapd, 1, "wpabuf_alloc;web_connection_parse_unsubscribe"): - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) headers = { "callback": '', "NT": "upnp:event", "timeout": "Second-1234" } @@ -9402,7 +9413,7 @@ def test_ap_wps_upnp_web_oom(dev, apdev, params): pass with alloc_fail(hapd, 1, "web_connection_unimplemented"): - conn = httplib.HTTPConnection(url.netloc) + conn = HTTPConnection(url.netloc) conn.request("HEAD", "/wps_device.xml") try: resp = conn.getresponse()