jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

WPS: Do not drop subscriptions based on max queue length

Browse source 
UPnP event subscriptions are not supposed to be dropped based on
whether events can be delivered quickly enough. Leave dropping to
happen only based on failed deliveries to avoid issues with a burst
of events kicking out still active subscribers.
This commit is contained in:
Jouni Malinen 2010-10-17 21:36:04 +03:00
parent f30e698c08
commit 99ba7f889b
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/wps/wps_upnp.c
View file

@ -527,13 +527,8 @@ static void upnp_wps_device_send_event(struct upnp_wps_device_sm *sm)
dl_list_for_each_safe(s, tmp, &sm->subscriptions, struct subscription, dl_list_for_each_safe(s, tmp, &sm->subscriptions, struct subscription,
list) { list) {
if (event_add(s, buf, sm->wlanevent_type == event_add(s, buf,
UPNP_WPS_WLANEVENT_TYPE_PROBE) == 1) { sm->wlanevent_type == UPNP_WPS_WLANEVENT_TYPE_PROBE);
wpa_printf(MSG_INFO, "WPS UPnP: Dropping "
"subscriber %p due to event backlog", s);
dl_list_del(&s->list);
subscription_destroy(s);
}
} }
wpabuf_free(buf); wpabuf_free(buf);