jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

tests: Optimize run-tests.py --prefill-tests startup time

Browse source 
It took significant part of the startup latency to prefill the database
with test cases due to the SQL COMMIT operation between each added row.
Move COMMIT to outside the loop to speed startup significantly.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2014-11-27 20:08:15 +02:00 committed by Jouni Malinen
parent b925506a91
commit 9363f5e065
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/hwsim/run-tests.py
View file

@ -76,7 +76,8 @@ def add_log_file(conn, test, run, type, path):
print "sqlite: " + str(e)
print "sql: %r" % (params, )
def report(conn, prefill, build, commit, run, test, result, duration, logdir):
def report(conn, prefill, build, commit, run, test, result, duration, logdir,
sql_commit=True):
if conn:
if not build:
build = ''
@ -88,7 +89,8 @@ def report(conn, prefill, build, commit, run, test, result, duration, logdir):
params = (test, result, run, time.time(), duration, build, commit)
try:
conn.execute(sql, params)
conn.commit()
if sql_commit:
conn.commit()
except Exception, e:
print "sqlite: " + str(e)
print "sql: %r" % (params, )
@ -329,7 +331,8 @@ def main():
for t in tests_to_run:
name = t.__name__.replace('test_', '', 1)
report(conn, False, args.build, args.commit, run, name, 'NOTRUN', 0,
args.logdir)
args.logdir, sql_commit=False)
conn.commit()
if args.split:
vals = args.split.split('/')