jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

WPS UPnP: Handle HTTP initiation failures for events more properly

Browse source 
While it is appropriate to try to retransmit the event to another
callback URL on a failure to initiate the HTTP client connection, there
is no point in trying the exact same operation multiple times in a row.
Replve the event_retry() calls with event_addr_failure() for these cases
to avoid busy loops trying to repeat the same failing operation.

These potential busy loops would go through eloop callbacks, so the
process is not completely stuck on handling them, but unnecessary CPU
would be used to process the continues retries that will keep failing
for the same reason.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
This commit is contained in:
Jouni Malinen 2020-06-04 21:24:04 +03:00 committed by Jouni Malinen
parent f7d268864a
commit 85aac526af
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/wps/wps_upnp_event.c
View file

@ -294,7 +294,7 @@ static int event_send_start(struct subscription *s)
buf = event_build_message(e); buf = event_build_message(e);
if (buf == NULL) { if (buf == NULL) {
event_retry(e, 0); event_addr_failure(e);
return -1; return -1;
} }
@ -302,7 +302,7 @@ static int event_send_start(struct subscription *s)
event_http_cb, e); event_http_cb, e);
if (e->http_event == NULL) { if (e->http_event == NULL) {
wpabuf_free(buf); wpabuf_free(buf);
event_retry(e, 0); event_addr_failure(e);
return -1; return -1;
} }