jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

nl80211: Avoid infinite loop when searching a BSS

Browse source 
When hostapd is removing a virtual BSS interface, the loop here was
incorrectly not updating the iterator during list traversal and
ended up in an infinite loop in some cases.
This commit is contained in:
Jouni Malinen 2011-01-09 19:18:50 +02:00
parent 4d379f1243
commit 8546ea1930
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/drivers/driver_nl80211.c
View file

@ -5775,17 +5775,20 @@ static int wpa_driver_nl80211_if_remove(void *priv,
return 0; return 0;
if (bss != &drv->first_bss) { if (bss != &drv->first_bss) {
struct i802_bss *tbss = &drv->first_bss; struct i802_bss *tbss;
while (tbss) {
if (tbss->next != bss)
continue;
for (tbss = &drv->first_bss; tbss; tbss = tbss->next) {
if (tbss->next == bss) {
tbss->next = bss->next; tbss->next = bss->next;
os_free(bss); os_free(bss);
bss = NULL;
break; break;
} }
} }
if (bss)
wpa_printf(MSG_INFO, "nl80211: %s - could not find "
"BSS %p in the list", __func__, bss);
}
#endif /* HOSTAPD */ #endif /* HOSTAPD */
return 0; return 0;