jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Make sha256_process() easier for static analyzers

Browse source 
md->curlen cannot indicate full buffer size here since the buffered
data is processed whenever the full block size of data is available.
Avoid invalid warnings from static analyzers on memcpy() outside the
buffer length by verifying that curlen is smaller than block size.

Signed-hostap: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2011-11-13 21:36:23 +02:00
parent 94a9ebb0b2
commit 7f6400ed19
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/crypto/sha256-internal.c
View file

@ -164,7 +164,7 @@ static int sha256_process(struct sha256_state *md, const unsigned char *in,
unsigned long n; unsigned long n;
#define block_size 64 #define block_size 64
if (md->curlen > sizeof(md->buf)) if (md->curlen >= sizeof(md->buf))
return -1; return -1;
while (inlen > 0) { while (inlen > 0) {