jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

EXT PW: Fix hash return in password fetching

Browse source 
The hash return buffer was previously left uninitialized in case
externally stored password ("password=ext:...") was used. This could
result in MSCHAPv2 failure if that uninitialized memory happened to be
something else than zero.

Signed-hostap: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2014-01-07 22:30:25 +02:00
parent 08081ad8ef
commit 7b88b64cd3
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/eap_peer/eap.c
View file

@ -2046,6 +2046,8 @@ const u8 * eap_get_config_password2(struct eap_sm *sm, size_t *len, int *hash)
if (config->flags & EAP_CONFIG_FLAGS_EXT_PASSWORD) { if (config->flags & EAP_CONFIG_FLAGS_EXT_PASSWORD) {
if (eap_get_ext_password(sm, config) < 0) if (eap_get_ext_password(sm, config) < 0)
return NULL; return NULL;
if (hash)
*hash = 0;
*len = wpabuf_len(sm->ext_pw_buf); *len = wpabuf_len(sm->ext_pw_buf);
return wpabuf_head(sm->ext_pw_buf); return wpabuf_head(sm->ext_pw_buf);
} }