From 78d338d1b1206844e4f0c3e03d227144044830e9 Mon Sep 17 00:00:00 2001 From: Alexander Wetzel Date: Fri, 20 Dec 2019 20:21:25 +0100 Subject: [PATCH] DPP: Fix a memory leak on an error path Fix a memory leak exposed by the dpp_own_config_sign_fail test. Fixes: 52d469de1112 ("DPP2: Support multiple Config Objects in Enrollee") Signed-off-by: Alexander Wetzel --- src/common/dpp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/common/dpp.c b/src/common/dpp.c index 0d0c47ec8..8c873fdf0 100644 --- a/src/common/dpp.c +++ b/src/common/dpp.c @@ -6859,8 +6859,11 @@ int dpp_configurator_own_config(struct dpp_authentication *auth, dpp_copy_csign(&auth->conf_obj[0], auth->conf->csign); conf_obj = dpp_build_conf_obj(auth, ap, 0); - if (!conf_obj) + if (!conf_obj) { + wpabuf_free(auth->conf_obj[0].c_sign_key); + auth->conf_obj[0].c_sign_key = NULL; goto fail; + } ret = dpp_parse_conf_obj(auth, wpabuf_head(conf_obj), wpabuf_len(conf_obj)); fail: