jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

mka: Remove unused authorization data from CP

Browse source 
While IEEE Std 802.1X-2010 talks about arbitrary authorization data that
could be passed to the CP from sources like RADIUS server, there is not
much point in trying to implement this as an arbitrary memory buffer in
wpa_supplicant. Should such data be supported in the future, it would
much more likely use more detailed data structures that encode the
received data in easier to use form.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2018-12-27 11:26:27 +02:00
parent ead573d8a2
commit 785b219abd
2 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/pae/ieee802_1x_cp.c
View file

@ -38,12 +38,10 @@ struct ieee802_1x_cp_sm {
/* Logon -> CP */ /* Logon -> CP */
enum connect_type connect; enum connect_type connect;
u8 *authorization_data;
/* KaY -> CP */ /* KaY -> CP */
Boolean chgd_server; /* clear by CP */ Boolean chgd_server; /* clear by CP */
Boolean elected_self; Boolean elected_self;
u8 *authorization_data1;
enum confidentiality_offset cipher_offset; enum confidentiality_offset cipher_offset;
u64 cipher_suite; u64 cipher_suite;
Boolean new_sak; /* clear by CP */ Boolean new_sak; /* clear by CP */
@ -468,7 +466,6 @@ struct ieee802_1x_cp_sm * ieee802_1x_cp_sm_init(struct ieee802_1x_kay *kay)
sm->retire_delay = MKA_SAK_RETIRE_TIME; sm->retire_delay = MKA_SAK_RETIRE_TIME;
sm->CP_state = CP_BEGIN; sm->CP_state = CP_BEGIN;
sm->changed = FALSE; sm->changed = FALSE;
sm->authorization_data = NULL;
wpa_printf(MSG_DEBUG, "CP: state machine created"); wpa_printf(MSG_DEBUG, "CP: state machine created");
@ -522,7 +519,6 @@ void ieee802_1x_cp_sm_deinit(struct ieee802_1x_cp_sm *sm)
eloop_cancel_timeout(ieee802_1x_cp_step_cb, sm, NULL); eloop_cancel_timeout(ieee802_1x_cp_step_cb, sm, NULL);
os_free(sm->lki); os_free(sm->lki);
os_free(sm->oki); os_free(sm->oki);
os_free(sm->authorization_data);
os_free(sm); os_free(sm);
} }
@ -592,19 +588,6 @@ void ieee802_1x_cp_set_electedself(void *cp_ctx, Boolean status)
} }
/**
* ieee802_1x_cp_set_authorizationdata -
*/
void ieee802_1x_cp_set_authorizationdata(void *cp_ctx, u8 *pdata, int len)
{
struct ieee802_1x_cp_sm *sm = cp_ctx;
os_free(sm->authorization_data);
sm->authorization_data = os_zalloc(len);
if (sm->authorization_data)
os_memcpy(sm->authorization_data, pdata, len);
}
/** /**
* ieee802_1x_cp_set_ciphersuite - * ieee802_1x_cp_set_ciphersuite -
*/ */

1
src/pae/ieee802_1x_cp.h
View file

@ -25,7 +25,6 @@ void ieee802_1x_cp_connect_authenticated(void *cp_ctx);
void ieee802_1x_cp_connect_secure(void *cp_ctx); void ieee802_1x_cp_connect_secure(void *cp_ctx);
void ieee802_1x_cp_signal_chgdserver(void *cp_ctx); void ieee802_1x_cp_signal_chgdserver(void *cp_ctx);
void ieee802_1x_cp_set_electedself(void *cp_ctx, Boolean status); void ieee802_1x_cp_set_electedself(void *cp_ctx, Boolean status);
void ieee802_1x_cp_set_authorizationdata(void *cp_ctx, u8 *pdata, int len);
void ieee802_1x_cp_set_ciphersuite(void *cp_ctx, u64 cs); void ieee802_1x_cp_set_ciphersuite(void *cp_ctx, u64 cs);
void ieee802_1x_cp_set_offset(void *cp_ctx, enum confidentiality_offset offset); void ieee802_1x_cp_set_offset(void *cp_ctx, enum confidentiality_offset offset);
void ieee802_1x_cp_signal_newsak(void *cp_ctx); void ieee802_1x_cp_signal_newsak(void *cp_ctx);