jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

HS 2.0: Fix hs20_get_icon() error path

Browse source 
If base64_encode() fails (e.g., due to memory allocation failure), the
return value needs to be checked against NULL before using the (not
really) returned length value. The error path here ended up reading
uninitialized variable.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2016-07-04 19:34:22 +03:00
parent 8e590f02bd
commit 75b2a87952
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
wpa_supplicant/hs20_supplicant.c
View file

@ -320,7 +320,7 @@ int hs20_get_icon(struct wpa_supplicant *wpa_s, const u8 *bssid,
return -1; return -1;
b64 = base64_encode(&icon->image[offset], size, &b64_size); b64 = base64_encode(&icon->image[offset], size, &b64_size);
if (buf_len >= b64_size) { if (b64 && buf_len >= b64_size) {
os_memcpy(reply, b64, b64_size); os_memcpy(reply, b64, b64_size);
reply_size = b64_size; reply_size = b64_size;
} else { } else {