jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

tests: Fix ap_ft_r0_key_expiration test

Browse source 
The test configures ft_r0_key_lifetime parameter, however ft_params
already contain the r0_key_lifetime. Since both options are accepted by
hostapd and set the same field, one of them gets overwritten.
As the dictionary enumeration order is not guaranteed in python, the
test may sporadically fail.
Fix that by explicitely removing the unneeded parameter.

Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
This commit is contained in:
Andrei Otcheretianski 2021-01-21 17:40:35 +02:00 committed by Jouni Malinen
parent 0b7895750b
commit 7546a70fbb
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/hwsim/test_ap_ft.py
View file

@ -3352,9 +3352,11 @@ def test_ap_ft_r0_key_expiration(dev, apdev):
passphrase = "12345678" passphrase = "12345678"
params = ft_params1(ssid=ssid, passphrase=passphrase) params = ft_params1(ssid=ssid, passphrase=passphrase)
params.pop('r0_key_lifetime', None)
params['ft_r0_key_lifetime'] = "2" params['ft_r0_key_lifetime'] = "2"
hapd0 = hostapd.add_ap(apdev[0], params) hapd0 = hostapd.add_ap(apdev[0], params)
params = ft_params2(ssid=ssid, passphrase=passphrase) params = ft_params2(ssid=ssid, passphrase=passphrase)
params.pop('r0_key_lifetime', None)
params['ft_r0_key_lifetime'] = "2" params['ft_r0_key_lifetime'] = "2"
hapd1 = hostapd.add_ap(apdev[1], params) hapd1 = hostapd.add_ap(apdev[1], params)