jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix RSN preauth candidate list clearing to avoid segfaults

Browse source 
Commit c5b26e33c1 broke the processing
of the candidate list entries when an old entry was either removed or
reused. The entry needs to be removed from the list to avoid leaving
pointers to freed memory.

http://bugs.gentoo.org/show_bug.cgi?id=330085
http://w1.fi/bugz/show_bug.cgi?id=372
This commit is contained in:
Daniel Gryniewicz 2010-08-14 19:01:14 +03:00 committed by Jouni Malinen
parent ba2d0d7d68
commit 6c78ae1443
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/rsn_supp/preauth.c
View file

@ -49,8 +49,10 @@ void pmksa_candidate_free(struct wpa_sm *sm)
return;
dl_list_for_each_safe(entry, n, &sm->pmksa_candidates,
struct rsn_pmksa_candidate, list)
struct rsn_pmksa_candidate, list) {
dl_list_del(&entry->list);
os_free(entry);
}
}
@ -378,6 +380,7 @@ void pmksa_candidate_add(struct wpa_sm *sm, const u8 *bssid,
}
if (cand) {
dl_list_del(&cand->list);
if (prio < PMKID_CANDIDATE_PRIO_SCAN)
cand->priority = prio;
} else {