From 6ac593ec4758ce06da76876d23a46ccb87c7dc47 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Mon, 22 Dec 2014 20:08:11 +0200 Subject: [PATCH] tests: Optimize run-tests.py test case dict iteration Use a single iteration through the module dictionary rather than iterating over the keys and separately fetching values to get the function. Signed-off-by: Jouni Malinen --- tests/hwsim/run-tests.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/hwsim/run-tests.py b/tests/hwsim/run-tests.py index 538b9ac5e..a4f768806 100755 --- a/tests/hwsim/run-tests.py +++ b/tests/hwsim/run-tests.py @@ -161,10 +161,9 @@ def main(): logger.debug("Import test cases from " + t) mod = __import__(m.group(1)) test_modules.append(mod.__name__.replace('test_', '', 1)) - for s in dir(mod): - if s.startswith("test_"): - func = mod.__dict__.get(s) - tests.append(func) + for key,val in mod.__dict__.iteritems(): + if key.startswith("test_"): + tests.append(val) test_names = list(set([t.__name__.replace('test_', '', 1) for t in tests])) run = None