From 65d0b67c228221fde8133d585a27588b8beb10fd Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Wed, 25 Dec 2019 23:35:40 +0200 Subject: [PATCH] mesh: Increase plink action frame AMPY buffer length for max GTK/IGTK The previous calculation of the buffer length did not take into account the possibility of 32-octet GTK and IGTK values and it was also missing something to cover the 16 octet keys that are supported now. Other buffer elements were likely sufficient to cover all these cases, but anyway, it is better to allocate sufficient size specifically for AMPE to avoid issues in the future. Signed-off-by: Jouni Malinen --- wpa_supplicant/mesh_mpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpa_supplicant/mesh_mpm.c b/wpa_supplicant/mesh_mpm.c index 4a163b6eb..308366f64 100644 --- a/wpa_supplicant/mesh_mpm.c +++ b/wpa_supplicant/mesh_mpm.c @@ -231,7 +231,7 @@ static void mesh_mpm_send_plink_action(struct wpa_supplicant *wpa_s, 2 + 32 + /* mesh ID */ 2 + 7 + /* mesh config */ 2 + 24 + /* peering management */ - 2 + 96 + /* AMPE */ + 2 + 96 + 32 + 32 + /* AMPE (96 + max GTKlen + max IGTKlen) */ 2 + 16; /* MIC */ #ifdef CONFIG_IEEE80211N if (type != PLINK_CLOSE && wpa_s->mesh_ht_enabled) {