jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Explicitly clear the temporary stack-based key for WPA-None

Browse source 
There is no need to leave this temporary key in stack memory after
having been configured to the driver.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2014-12-29 13:09:24 +02:00
parent f42df14415
commit 658da804e5
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
wpa_supplicant/wpa_supplicant.c
View file

@ -132,6 +132,7 @@ int wpa_supplicant_set_wpa_none_key(struct wpa_supplicant *wpa_s,
size_t keylen; size_t keylen;
enum wpa_alg alg; enum wpa_alg alg;
u8 seq[6] = { 0 }; u8 seq[6] = { 0 };
int ret;
/* IBSS/WPA-None uses only one key (Group) for both receiving and /* IBSS/WPA-None uses only one key (Group) for both receiving and
* sending unicast and multicast packets. */ * sending unicast and multicast packets. */
@ -175,7 +176,9 @@ int wpa_supplicant_set_wpa_none_key(struct wpa_supplicant *wpa_s,
/* TODO: should actually remember the previously used seq#, both for TX /* TODO: should actually remember the previously used seq#, both for TX
* and RX from each STA.. */ * and RX from each STA.. */
return wpa_drv_set_key(wpa_s, alg, NULL, 0, 1, seq, 6, key, keylen); ret = wpa_drv_set_key(wpa_s, alg, NULL, 0, 1, seq, 6, key, keylen);
os_memset(key, 0, sizeof(key));
return ret;
} }