From 649038e1175bb19b875fb5dea0ac5009203a26b6 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Fri, 15 Mar 2019 22:42:18 +0200 Subject: [PATCH] tests: Remove unnecessary second wait from connect_cmd_reject_assoc It does not look like there would be two CTRL-EVENT-ASSOC-REJECT events here, so only check the first one instead of requiring both to be received with status_code=27. This test case could fail based on the second connection attempt (due to that extra event wait) timing out. Signed-off-by: Jouni Malinen --- tests/hwsim/test_connect_cmd.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/tests/hwsim/test_connect_cmd.py b/tests/hwsim/test_connect_cmd.py index d2f66a497..630ea224f 100644 --- a/tests/hwsim/test_connect_cmd.py +++ b/tests/hwsim/test_connect_cmd.py @@ -130,14 +130,11 @@ def test_connect_cmd_reject_assoc(dev, apdev): wpas.interface_add("wlan5", drv_params="force_connect_cmd=1") wpas.connect("sta-connect", key_mgmt="NONE", scan_freq="2412", disable_ht="1", wait_connect=False) - # Reject event gets reported twice since we force connect command to be used - # with a driver that supports auth+assoc for testing purposes. - for i in range(0, 2): - ev = wpas.wait_event(["CTRL-EVENT-ASSOC-REJECT"], timeout=15) - if ev is None: - raise Exception("Association rejection timed out") - if "status_code=27" not in ev: - raise Exception("Unexpected rejection status code") + ev = wpas.wait_event(["CTRL-EVENT-ASSOC-REJECT"], timeout=15) + if ev is None: + raise Exception("Association rejection timed out") + if "status_code=27" not in ev: + raise Exception("Unexpected rejection status code") wpas.request("DISCONNECT") wpas.dump_monitor()