From 5dbbf36916f5cd796206809da7592dc2554bb4ae Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Mon, 30 Jun 2014 01:08:49 +0300 Subject: [PATCH] Interworking: Remove unnecessary dead increment build_root_nai() will not be extended to write something after the domain, so there is no need to update the pos pointer after the final os_snprintf() call in the function. Remove this to make a static analyzer happier. Signed-off-by: Jouni Malinen --- wpa_supplicant/interworking.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wpa_supplicant/interworking.c b/wpa_supplicant/interworking.c index bbee951bb..45a8f69c0 100644 --- a/wpa_supplicant/interworking.c +++ b/wpa_supplicant/interworking.c @@ -796,8 +796,8 @@ static int build_root_nai(char *nai, size_t nai_len, const char *imsi, *pos++ = imsi[4]; *pos++ = imsi[5]; } - pos += os_snprintf(pos, end - pos, ".mcc%c%c%c.3gppnetwork.org", - imsi[0], imsi[1], imsi[2]); + os_snprintf(pos, end - pos, ".mcc%c%c%c.3gppnetwork.org", + imsi[0], imsi[1], imsi[2]); return 0; }