jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

hs20-osu-client: Fix pol_upd command line parsing

Browse source 
This command was documented as having the Server URL parameter as
optional, but the implementation did not match that. Allow this
parameter to be left out.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2016-03-16 21:25:11 +02:00 committed by Jouni Malinen
parent ec1eae849e
commit 42a95533a8
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
hs20/client/osu_client.c
View file

@ -2570,7 +2570,7 @@ static int cmd_pol_upd(struct hs20_osu_client *ctx, const char *address,
if (!pps_fname) { if (!pps_fname) {
char buf[256]; char buf[256];
wpa_printf(MSG_INFO, "Determining PPS file based on Home SP information"); wpa_printf(MSG_INFO, "Determining PPS file based on Home SP information");
if (os_strncmp(address, "fqdn=", 5) == 0) { if (address && os_strncmp(address, "fqdn=", 5) == 0) {
wpa_printf(MSG_INFO, "Use requested FQDN from command line"); wpa_printf(MSG_INFO, "Use requested FQDN from command line");
os_snprintf(buf, sizeof(buf), "%s", address + 5); os_snprintf(buf, sizeof(buf), "%s", address + 5);
address = NULL; address = NULL;
@ -3137,11 +3137,8 @@ int main(int argc, char *argv[])
argc > optind + 2 ? argv[optind + 2] : NULL, argc > optind + 2 ? argv[optind + 2] : NULL,
argc > optind + 3 ? argv[optind + 3] : NULL); argc > optind + 3 ? argv[optind + 3] : NULL);
} else if (strcmp(argv[optind], "pol_upd") == 0) { } else if (strcmp(argv[optind], "pol_upd") == 0) {
if (argc - optind < 2) { ret = cmd_pol_upd(&ctx,
usage(); argc > optind + 1 ? argv[optind + 1] : NULL,
exit(0);
}
ret = cmd_pol_upd(&ctx, argc > 2 ? argv[optind + 1] : NULL,
argc > optind + 2 ? argv[optind + 2] : NULL, argc > optind + 2 ? argv[optind + 2] : NULL,
argc > optind + 3 ? argv[optind + 3] : NULL); argc > optind + 3 ? argv[optind + 3] : NULL);
} else if (strcmp(argv[optind], "prov") == 0) { } else if (strcmp(argv[optind], "prov") == 0) {