jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

UBSan: Avoid a warning on signed left shift

Browse source 
Use unsigned 1 (1U) instead of signed (1) when doing left shift that
could potentially need to use all bits of the 32-bit unsigned variable.

radius_server.c:2254:14: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2019-02-23 18:43:38 +02:00
parent b3957edbe9
commit 429ed54a3d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/radius/radius_server.c
View file

@ -1,6 +1,6 @@
/* /*
* RADIUS authentication server * RADIUS authentication server
* Copyright (c) 2005-2009, 2011-2014, Jouni Malinen <j@w1.fi> * Copyright (c) 2005-2009, 2011-2019, Jouni Malinen <j@w1.fi>
* *
* This software may be distributed under the terms of the BSD license. * This software may be distributed under the terms of the BSD license.
* See README for more details. * See README for more details.
@ -2251,7 +2251,7 @@ radius_server_read_clients(const char *client_file, int ipv6)
entry->addr.s_addr = addr.s_addr; entry->addr.s_addr = addr.s_addr;
val = 0; val = 0;
for (i = 0; i < mask; i++) for (i = 0; i < mask; i++)
val |= 1 << (31 - i); val |= 1U << (31 - i);
entry->mask.s_addr = htonl(val); entry->mask.s_addr = htonl(val);
} }
#ifdef CONFIG_IPV6 #ifdef CONFIG_IPV6