jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Return error from wpa_drv_get_pref_freq_list() if no driver support

Browse source 
Commit 983422088f ('nl80211: Add means to
query preferred channels') return success if no driver wrapper callback
was provided for fetching the preferred channel list. That is
problematic since the *num argument is not updated and uninitialized
freq_list could end up getting used with arbitrary frequency values. Fix
this by returning error in case the values were not available due to
driver wrapper not implementing the function. This matches the style
used in the driver_nl80211.c implementation for the case where the
driver does not support such fetch operation.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2015-07-30 22:10:46 +03:00 committed by Jouni Malinen
parent 983422088f
commit 34c5267bbc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
wpa_supplicant/driver_i.h
View file

@ -899,7 +899,7 @@ static inline int wpa_drv_get_pref_freq_list(struct wpa_supplicant *wpa_s,
unsigned int *freq_list) unsigned int *freq_list)
{ {
if (!wpa_s->driver->get_pref_freq_list) if (!wpa_s->driver->get_pref_freq_list)
return 0; return -1;
return wpa_s->driver->get_pref_freq_list(wpa_s->drv_priv, if_type, return wpa_s->driver->get_pref_freq_list(wpa_s->drv_priv, if_type,
num, freq_list); num, freq_list);
} }