jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

wpa_passphrase: Output errors to stderr

Browse source 
The stdout of wpa_passphrase is often piped directly into the
wpa_supplicant config file. In case of errors these will be written to
the file and possibly not noticed by the user.

Use fprintf to print errors to stderr.

Signed-off-by: Sam Tygier <samtygier@yahoo.co.uk>
This commit is contained in:
Sam Tygier 2019-12-23 15:20:20 +00:00 committed by Jouni Malinen
parent ce1598d4c2
commit 32289112c4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
wpa_supplicant/wpa_passphrase.c
View file

@ -31,9 +31,9 @@ int main(int argc, char *argv[])
if (argc > 2) { if (argc > 2) {
passphrase = argv[2]; passphrase = argv[2];
} else { } else {
printf("# reading passphrase from stdin\n"); fprintf(stderr, "# reading passphrase from stdin\n");
if (fgets(buf, sizeof(buf), stdin) == NULL) { if (fgets(buf, sizeof(buf), stdin) == NULL) {
printf("Failed to read passphrase\n"); fprintf(stderr, "Failed to read passphrase\n");
return 1; return 1;
} }
buf[sizeof(buf) - 1] = '\0'; buf[sizeof(buf) - 1] = '\0';
@ -50,11 +50,11 @@ int main(int argc, char *argv[])
len = os_strlen(passphrase); len = os_strlen(passphrase);
if (len < 8 || len > 63) { if (len < 8 || len > 63) {
printf("Passphrase must be 8..63 characters\n"); fprintf(stderr, "Passphrase must be 8..63 characters\n");
return 1; return 1;
} }
if (has_ctrl_char((u8 *) passphrase, len)) { if (has_ctrl_char((u8 *) passphrase, len)) {
printf("Invalid passphrase character\n"); fprintf(stderr, "Invalid passphrase character\n");
return 1; return 1;
} }