SAE H2E: Check H2E-only BSS membership selector only if SAE is enabled

This BSS membership selector has impact only for SAE functionality, so
ignore it when configured not to use SAE. This allows WPA-PSK connection
to and AP that advertises WPA-PSK and SAE while requiring H2E for SAE.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
This commit is contained in:
Jouni Malinen 2020-01-20 20:23:48 +02:00 committed by Jouni Malinen
parent f124367afb
commit 29dd0b3164

View file

@ -772,8 +772,8 @@ static int freq_allowed(int *freqs, int freq)
} }
static int rate_match(struct wpa_supplicant *wpa_s, struct wpa_bss *bss, static int rate_match(struct wpa_supplicant *wpa_s, struct wpa_ssid *ssid,
int debug_print) struct wpa_bss *bss, int debug_print)
{ {
const struct hostapd_hw_modes *mode = NULL, *modes; const struct hostapd_hw_modes *mode = NULL, *modes;
const u8 scan_ie[2] = { WLAN_EID_SUPP_RATES, WLAN_EID_EXT_SUPP_RATES }; const u8 scan_ie[2] = { WLAN_EID_SUPP_RATES, WLAN_EID_EXT_SUPP_RATES };
@ -853,7 +853,8 @@ static int rate_match(struct wpa_supplicant *wpa_s, struct wpa_bss *bss,
#ifdef CONFIG_SAE #ifdef CONFIG_SAE
if (flagged && ((rate_ie[j] & 0x7f) == if (flagged && ((rate_ie[j] & 0x7f) ==
BSS_MEMBERSHIP_SELECTOR_SAE_H2E_ONLY)) { BSS_MEMBERSHIP_SELECTOR_SAE_H2E_ONLY)) {
if (wpa_s->conf->sae_pwe == 0) { if (wpa_s->conf->sae_pwe == 0 &&
wpa_key_mgmt_sae(ssid->key_mgmt)) {
if (debug_print) if (debug_print)
wpa_dbg(wpa_s, MSG_DEBUG, wpa_dbg(wpa_s, MSG_DEBUG,
" SAE H2E disabled"); " SAE H2E disabled");
@ -1290,7 +1291,7 @@ struct wpa_ssid * wpa_scan_res_match(struct wpa_supplicant *wpa_s,
} }
#endif /* CONFIG_MESH */ #endif /* CONFIG_MESH */
if (!rate_match(wpa_s, bss, debug_print)) { if (!rate_match(wpa_s, ssid, bss, debug_print)) {
if (debug_print) if (debug_print)
wpa_dbg(wpa_s, MSG_DEBUG, wpa_dbg(wpa_s, MSG_DEBUG,
" skip - rate sets do not match"); " skip - rate sets do not match");