From 28c7f77a85c31224e0065fdea0f4204ded4671e0 Mon Sep 17 00:00:00 2001 From: Nachiket Kukade Date: Fri, 10 Aug 2018 16:54:09 +0530 Subject: [PATCH] Correct the documentation of NAN vendor command Present implementation of NAN vendor command does not use attribute encapsulation for sending the command from userspace to the driver, payload is directly sent as is. Attribute QCA_WLAN_VENDOR_ATTR_NAN is used only for receiving vendor events in the userspace from the driver. Update the doc as per this implementation. Signed-off-by: Jouni Malinen --- src/common/qca-vendor.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/common/qca-vendor.h b/src/common/qca-vendor.h index e89f27665..4f247863d 100644 --- a/src/common/qca-vendor.h +++ b/src/common/qca-vendor.h @@ -50,7 +50,10 @@ enum qca_radiotap_vendor_ids { * * @QCA_NL80211_VENDOR_SUBCMD_NAN: NAN command/event which is used to pass * NAN Request/Response and NAN Indication messages. These messages are - * interpreted between the framework and the firmware component. + * interpreted between the framework and the firmware component. While + * sending the command from userspace to the driver, payload is not + * encapsulated inside any attribute. Attribute QCA_WLAN_VENDOR_ATTR_NAN + * is used when receiving vendor events in userspace from the driver. * * @QCA_NL80211_VENDOR_SUBCMD_KEY_MGMT_SET_KEY: Set key operation that can be * used to configure PMK to the driver even when not connected. This can @@ -618,7 +621,10 @@ enum qca_wlan_vendor_attr { QCA_WLAN_VENDOR_ATTR_INVALID = 0, /* used by QCA_NL80211_VENDOR_SUBCMD_DFS_CAPABILITY */ QCA_WLAN_VENDOR_ATTR_DFS = 1, - /* used by QCA_NL80211_VENDOR_SUBCMD_NAN */ + /* Used only when driver sends vendor events to the userspace under the + * command QCA_NL80211_VENDOR_SUBCMD_NAN. Not used when userspace sends + * commands to the driver. + */ QCA_WLAN_VENDOR_ATTR_NAN = 2, /* used by QCA_NL80211_VENDOR_SUBCMD_STATS_EXT */ QCA_WLAN_VENDOR_ATTR_STATS_EXT = 3,