jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

crypto: Fix unreachable code in tls_prf_sha1_md5()

Browse source 
While commit 1c156e783d ("Fixed tls_prf() to handle keys with
odd length") added support for keys with odd length, the function
never reached this code as the function would return earlier in
case the key length was odd. Fix this by removing the first check
for the key length.

Signed-off-by: Ilan Peer <ilan.peer@intel.com>
This commit is contained in:
Ilan Peer 2019-04-03 15:16:14 +03:00 committed by Jouni Malinen
parent 78ed42d8a2
commit 277fa92b37
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/crypto/sha1-tlsprf.c
View file

@ -40,9 +40,6 @@ int tls_prf_sha1_md5(const u8 *secret, size_t secret_len, const char *label,
const unsigned char *SHA1_addr[3]; const unsigned char *SHA1_addr[3];
size_t SHA1_len[3]; size_t SHA1_len[3];
if (secret_len & 1)
return -1;
MD5_addr[0] = A_MD5; MD5_addr[0] = A_MD5;
MD5_len[0] = MD5_MAC_LEN; MD5_len[0] = MD5_MAC_LEN;
MD5_addr[1] = (unsigned char *) label; MD5_addr[1] = (unsigned char *) label;