jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

mesh: Fix channel configuration in pri/sec switch case

Browse source 
If 20/40 MHz co-ex scan resulted in switching primary and secondary
channels, mesh setup failed to update the frequency parameters for
hostapd side configuration and that could result in invalid secondary
channel configuration preventing creating of the mesh network. This
could happen, e.g., when trying to set up mesh on 5 GHz channel 36 and
co-ex scan finding a BSS on channel 40. Switching the pri/sec channels
resulted in hostapd code trying to check whether channel 32 is
available. Fix this by swapping the channels for hostapd configuration
when needed.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2016-12-13 15:25:52 +02:00 committed by Jouni Malinen
parent cebda0e3e5
commit 274e76f22f
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
wpa_supplicant/mesh.c
View file

@ -146,7 +146,8 @@ static void wpas_mesh_copy_groups(struct hostapd_data *bss,
static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s, static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
struct wpa_ssid *ssid) struct wpa_ssid *ssid,
struct hostapd_freq_params *freq)
{ {
struct hostapd_iface *ifmsh; struct hostapd_iface *ifmsh;
struct hostapd_data *bss; struct hostapd_data *bss;
@ -156,6 +157,7 @@ static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
static int default_groups[] = { 19, 20, 21, 25, 26, -1 }; static int default_groups[] = { 19, 20, 21, 25, 26, -1 };
size_t len; size_t len;
int rate_len; int rate_len;
int frequency;
if (!wpa_s->conf->user_mpm) { if (!wpa_s->conf->user_mpm) {
/* not much for us to do here */ /* not much for us to do here */
@ -185,7 +187,13 @@ static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
bss->drv_priv = wpa_s->drv_priv; bss->drv_priv = wpa_s->drv_priv;
bss->iface = ifmsh; bss->iface = ifmsh;
bss->mesh_sta_free_cb = mesh_mpm_free_sta; bss->mesh_sta_free_cb = mesh_mpm_free_sta;
wpa_s->assoc_freq = ssid->frequency; frequency = ssid->frequency;
if (frequency != freq->freq &&
frequency == freq->freq + freq->sec_channel_offset * 20) {
wpa_printf(MSG_DEBUG, "mesh: pri/sec channels switched");
frequency = freq->freq;
}
wpa_s->assoc_freq = frequency;
wpa_s->current_ssid = ssid; wpa_s->current_ssid = ssid;
/* setup an AP config for auth processing */ /* setup an AP config for auth processing */
@ -211,10 +219,10 @@ static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
ifmsh->mconf = mconf; ifmsh->mconf = mconf;
/* need conf->hw_mode for supported rates. */ /* need conf->hw_mode for supported rates. */
conf->hw_mode = ieee80211_freq_to_chan(ssid->frequency, &conf->channel); conf->hw_mode = ieee80211_freq_to_chan(frequency, &conf->channel);
if (conf->hw_mode == NUM_HOSTAPD_MODES) { if (conf->hw_mode == NUM_HOSTAPD_MODES) {
wpa_printf(MSG_ERROR, "Unsupported mesh mode frequency: %d MHz", wpa_printf(MSG_ERROR, "Unsupported mesh mode frequency: %d MHz",
ssid->frequency); frequency);
goto out_free; goto out_free;
} }
if (ssid->ht40) if (ssid->ht40)
@ -225,13 +233,13 @@ static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
case VHT_CHANWIDTH_80MHZ: case VHT_CHANWIDTH_80MHZ:
case VHT_CHANWIDTH_80P80MHZ: case VHT_CHANWIDTH_80P80MHZ:
ieee80211_freq_to_chan( ieee80211_freq_to_chan(
ssid->frequency, frequency,
&conf->vht_oper_centr_freq_seg0_idx); &conf->vht_oper_centr_freq_seg0_idx);
conf->vht_oper_centr_freq_seg0_idx += ssid->ht40 * 2; conf->vht_oper_centr_freq_seg0_idx += ssid->ht40 * 2;
break; break;
case VHT_CHANWIDTH_160MHZ: case VHT_CHANWIDTH_160MHZ:
ieee80211_freq_to_chan( ieee80211_freq_to_chan(
ssid->frequency, frequency,
&conf->vht_oper_centr_freq_seg0_idx); &conf->vht_oper_centr_freq_seg0_idx);
conf->vht_oper_centr_freq_seg0_idx += ssid->ht40 * 2; conf->vht_oper_centr_freq_seg0_idx += ssid->ht40 * 2;
conf->vht_oper_centr_freq_seg0_idx += 40 / 5; conf->vht_oper_centr_freq_seg0_idx += 40 / 5;
@ -422,7 +430,7 @@ int wpa_supplicant_join_mesh(struct wpa_supplicant *wpa_s,
} }
params.conf.peer_link_timeout = wpa_s->conf->mesh_max_inactivity; params.conf.peer_link_timeout = wpa_s->conf->mesh_max_inactivity;
if (wpa_supplicant_mesh_init(wpa_s, ssid)) { if (wpa_supplicant_mesh_init(wpa_s, ssid, &params.freq)) {
wpa_msg(wpa_s, MSG_ERROR, "Failed to init mesh"); wpa_msg(wpa_s, MSG_ERROR, "Failed to init mesh");
wpa_drv_leave_mesh(wpa_s); wpa_drv_leave_mesh(wpa_s);
ret = -1; ret = -1;