jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

WMM AC: Do not write ERROR level log entries when WMM AC is not in use

Browse source 
These two wpa_printf() calls with MSG_ERROR level could be reached when
connecting without (Re)Association Response frame elements being
available. That would be the case for wired connections and IBSS. Those
cases are not supposed to use WMM AC in the first place, so do not
confuse logs with ERROR messages in them for normal conditions.

Signed-off-by: Jouni Malinen <j@w1.fi>
This commit is contained in:
Jouni Malinen 2018-12-08 16:48:33 +02:00
parent 30810f5d97
commit 22d8bb04d9
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
wpa_supplicant/wmm_ac.c
View file

@ -471,13 +471,8 @@ static int wmm_ac_init(struct wpa_supplicant *wpa_s, const u8 *ies,
return -1;
}
if (!ies) {
wpa_printf(MSG_ERROR, "WMM AC: Missing IEs");
return -1;
}
if (!(wmm_params->info_bitmap & WMM_PARAMS_UAPSD_QUEUES_INFO)) {
wpa_printf(MSG_DEBUG, "WMM AC: Missing U-APSD configuration");
if (!ies || !(wmm_params->info_bitmap & WMM_PARAMS_UAPSD_QUEUES_INFO)) {
/* WMM AC not in use for this connection */
return -1;
}