jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Clear control interface command explicitly from stack

Browse source 
The control interface commands may include passwords or other private
key material, so clear it explicitly from memory as soon as the
temporary buffer is not needed anymore.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2015-06-17 16:29:33 +03:00 committed by Jouni Malinen
parent d95c5994c8
commit 14fd03312c
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
wpa_supplicant/ctrl_iface_unix.c
View file

@ -197,6 +197,13 @@ static void wpa_supplicant_ctrl_iface_receive(int sock, void *eloop_ctx,
reply_buf = wpa_supplicant_ctrl_iface_process(wpa_s, buf, reply_buf = wpa_supplicant_ctrl_iface_process(wpa_s, buf,
&reply_len); &reply_len);
reply = reply_buf; reply = reply_buf;
/*
* There could be some password/key material in the command, so
* clear the buffer explicitly now that it is not needed
* anymore.
*/
os_memset(buf, 0, res);
} }
if (!reply && reply_len == 1) { if (!reply && reply_len == 1) {
@ -846,6 +853,13 @@ static void wpa_supplicant_global_ctrl_iface_receive(int sock, void *eloop_ctx,
reply_buf = wpa_supplicant_global_ctrl_iface_process( reply_buf = wpa_supplicant_global_ctrl_iface_process(
global, buf, &reply_len); global, buf, &reply_len);
reply = reply_buf; reply = reply_buf;
/*
* There could be some password/key material in the command, so
* clear the buffer explicitly now that it is not needed
* anymore.
*/
os_memset(buf, 0, res);
} }
if (!reply && reply_len == 1) { if (!reply && reply_len == 1) {