jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

nl80211: Indicate interface-down event only for the main netdev

Browse source 
RTM_NEWLINK event without IFF_UP were processed for all related
interfaces (including VLANs and bridge). While these events may need to
be processed for other purposes, they should not end up claiming that
the main interface has been disabled, so indicate
EVENT_INTERFACE_DISABLED only if the ifname matches the first BSS ifname
for the interface. In addition, fix some of the ifup/down checks from
if_indextoname() cases to actually use the resolved ifname (namebuf)
rather than hardcoding the first configured ifname to be used.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
This commit is contained in:
Jouni Malinen 2015-02-11 10:26:26 +02:00 committed by Jouni Malinen
parent eeb1cb28a2
commit 106fa1e97e
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/drivers/driver_nl80211.c
View file

@ -952,16 +952,21 @@ static void wpa_driver_nl80211_event_rtm_newlink(void *ctx,
(ifi->ifi_flags & IFF_DORMANT) ? "[DORMANT]" : ""); (ifi->ifi_flags & IFF_DORMANT) ? "[DORMANT]" : "");
if (!drv->if_disabled && !(ifi->ifi_flags & IFF_UP)) { if (!drv->if_disabled && !(ifi->ifi_flags & IFF_UP)) {
namebuf[0] = '\0';
if (if_indextoname(ifi->ifi_index, namebuf) && if (if_indextoname(ifi->ifi_index, namebuf) &&
linux_iface_up(drv->global->ioctl_sock, linux_iface_up(drv->global->ioctl_sock, namebuf) > 0) {
drv->first_bss->ifname) > 0) {
wpa_printf(MSG_DEBUG, "nl80211: Ignore interface down " wpa_printf(MSG_DEBUG, "nl80211: Ignore interface down "
"event since interface %s is up", namebuf); "event since interface %s is up", namebuf);
drv->ignore_if_down_event = 0; drv->ignore_if_down_event = 0;
return; return;
} }
wpa_printf(MSG_DEBUG, "nl80211: Interface down"); wpa_printf(MSG_DEBUG, "nl80211: Interface down (%s/%s)",
if (drv->ignore_if_down_event) { namebuf, ifname);
if (os_strcmp(drv->first_bss->ifname, ifname) != 0) {
wpa_printf(MSG_DEBUG,
"nl80211: Not the main interface (%s) - do not indicate interface down",
drv->first_bss->ifname);
} else if (drv->ignore_if_down_event) {
wpa_printf(MSG_DEBUG, "nl80211: Ignore interface down " wpa_printf(MSG_DEBUG, "nl80211: Ignore interface down "
"event generated by mode change"); "event generated by mode change");
drv->ignore_if_down_event = 0; drv->ignore_if_down_event = 0;
@ -984,8 +989,7 @@ static void wpa_driver_nl80211_event_rtm_newlink(void *ctx,
if (drv->if_disabled && (ifi->ifi_flags & IFF_UP)) { if (drv->if_disabled && (ifi->ifi_flags & IFF_UP)) {
if (if_indextoname(ifi->ifi_index, namebuf) && if (if_indextoname(ifi->ifi_index, namebuf) &&
linux_iface_up(drv->global->ioctl_sock, linux_iface_up(drv->global->ioctl_sock, namebuf) == 0) {
drv->first_bss->ifname) == 0) {
wpa_printf(MSG_DEBUG, "nl80211: Ignore interface up " wpa_printf(MSG_DEBUG, "nl80211: Ignore interface up "
"event since interface %s is down", "event since interface %s is down",
namebuf); namebuf);