jeltz/hostap
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

HS 2.0 server: Fix couple of memory leaks

Browse source 
Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
This commit is contained in:
Jouni Malinen 2018-12-04 14:12:44 +02:00 committed by Jouni Malinen
parent 718346775d
commit 0e1ab324cc
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
hs20/server/spp_server.c
View file

@ -754,8 +754,10 @@ static xml_node_t * build_sub_rem_resp(struct hs20_svc *ctx,
} }
cert = db_get_val(ctx, user, realm, "cert", dmacc); cert = db_get_val(ctx, user, realm, "cert", dmacc);
if (cert && cert[0] == '\0') if (cert && cert[0] == '\0') {
os_free(cert);
cert = NULL; cert = NULL;
}
if (cert) { if (cert) {
cred = build_credential_cert(ctx, real_user ? real_user : user, cred = build_credential_cert(ctx, real_user ? real_user : user,
realm, cert); realm, cert);
@ -781,6 +783,7 @@ static xml_node_t * build_sub_rem_resp(struct hs20_svc *ctx,
free(real_user); free(real_user);
if (!cred) { if (!cred) {
debug_print(ctx, 1, "Could not build credential"); debug_print(ctx, 1, "Could not build credential");
os_free(cert);
return NULL; return NULL;
} }
@ -789,6 +792,7 @@ static xml_node_t * build_sub_rem_resp(struct hs20_svc *ctx,
NULL); NULL);
if (spp_node == NULL) { if (spp_node == NULL) {
debug_print(ctx, 1, "Could not build sppPostDevDataResponse"); debug_print(ctx, 1, "Could not build sppPostDevDataResponse");
os_free(cert);
return NULL; return NULL;
} }
@ -799,6 +803,7 @@ static xml_node_t * build_sub_rem_resp(struct hs20_svc *ctx,
if (add_update_node(ctx, spp_node, ns, buf, cred) < 0) { if (add_update_node(ctx, spp_node, ns, buf, cred) < 0) {
debug_print(ctx, 1, "Could not add update node"); debug_print(ctx, 1, "Could not add update node");
xml_node_free(ctx->xml, spp_node); xml_node_free(ctx->xml, spp_node);
os_free(cert);
return NULL; return NULL;
} }
@ -817,6 +822,7 @@ static xml_node_t * build_sub_rem_resp(struct hs20_svc *ctx,
db_add_session(ctx, user, realm, session_id, new_pw, NULL, db_add_session(ctx, user, realm, session_id, new_pw, NULL,
UPDATE_PASSWORD, NULL); UPDATE_PASSWORD, NULL);
} }
os_free(cert);
return spp_node; return spp_node;
} }