From 01dd2b10548f28ce3fe45a6f4b32307c7f21eafa Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Mon, 1 May 2017 22:06:53 +0300 Subject: [PATCH] ERP: Silence static analyzer warning The check for erp->keyname_nai within eap_erp_get_key() is apparently too difficult for some static analyzers to notice. Add an explicit check for os_strchr() return value being non-NULL to avoid false reports. Signed-off-by: Jouni Malinen --- src/eap_peer/eap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/eap_peer/eap.c b/src/eap_peer/eap.c index d0f305f1a..5ca24603e 100644 --- a/src/eap_peer/eap.c +++ b/src/eap_peer/eap.c @@ -534,6 +534,8 @@ int eap_peer_get_erp_info(struct eap_sm *sm, struct eap_peer_config *config, return -1; /* SEQ has range of 0..65535 */ pos = os_strchr(erp->keyname_nai, '@'); + if (!pos) + return -1; /* this cannot really happen */ *username_len = pos - erp->keyname_nai; *username = (u8 *) erp->keyname_nai;