Certbot: handlers #1

Merged

otthorn merged 2 commits from handlers into master

2021-01-20 17:00:33 +01:00

otthorn commented

2021-01-19 23:33:13 +01:00

Owner

Use handlers instead of register variables -- (fix ansible-lint rule 503).
The purpose of handlers is to be run when their a modification
use command instead of shell when you don't need sh features (pipes, env, etc...) -- (fix ansible-lint fule 305).

Also some refactoring, I don't think there is any need to stop and restart nginx to generate certificates. I was unable to find any doc saying this. Reload should work just fine.

/!\ CAUTION: this is untested. I've been careful writting it, but an error could have slipped by.

- Use handlers instead of register variables -- (fix ansible-lint rule 503). The purpose of handlers is to be run when their a modification - use command instead of shell when you don't need sh features (pipes, env, etc...) -- (fix ansible-lint fule 305). Also some refactoring, I don't think there is any need to stop and restart nginx to generate certificates. I was unable to find any doc saying this. Reload should work just fine. /!\ CAUTION: this is untested. I've been careful writting it, but an error could have slipped by.

otthorn referenced this pull request from a commit

2021-01-20 17:00:33 +01:00

Merge pull request 'Certbot: handlers' (#1) from handlers into master Reviewed-on: https://gitea.auro.re/Aurore/ansible/pulls/1

otthorn merged commit 724d21485c into master

2021-01-20 17:00:33 +01:00

otthorn deleted branch handlers

2021-01-22 11:21:10 +01:00

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aurore/ansible#1

No description provided.