From 5551fb5c16186b9acee3a9455c44b44dfa02e387 Mon Sep 17 00:00:00 2001 From: Hadrien Patte Date: Sat, 23 Mar 2019 19:13:02 +0100 Subject: [PATCH] Fix: remove unnecessary quotes Signed-off-by: Hadrien Patte --- roles/baseconfig/tasks/main.yml | 8 ++++---- roles/codimd/tasks/0_apt_dependencies.yml | 2 +- roles/codimd/tasks/main.yml | 4 ++-- roles/ldap-client/handlers/main.yml | 2 +- roles/ldap-client/tasks/1_group_security.yml | 8 ++++---- roles/ldap-client/tasks/2_userland_scripts.yml | 2 +- roles/ldap-replica/tasks/main.yml | 6 +++--- roles/matrix-appservice-discord/tasks/main.yml | 4 ++-- roles/matrix-appservice-irc/tasks/main.yml | 4 ++-- roles/matrix-appservice-webhooks/tasks/main.yml | 4 ++-- roles/matrix-riot/tasks/main.yml | 2 +- roles/nginx-reverse-proxy/tasks/main.yml | 10 +++++----- 12 files changed, 28 insertions(+), 28 deletions(-) diff --git a/roles/baseconfig/tasks/main.yml b/roles/baseconfig/tasks/main.yml index 447b046..9cc21b1 100644 --- a/roles/baseconfig/tasks/main.yml +++ b/roles/baseconfig/tasks/main.yml @@ -23,8 +23,8 @@ # Pimp my server - name: Customize motd copy: - src: 'update-motd.d/00-logo' - dest: '/etc/update-motd.d/00-logo' + src: update-motd.d/00-logo + dest: /etc/update-motd.d/00-logo mode: 0755 # Configure APT mirrors on Debian Stretch @@ -33,8 +33,8 @@ - ansible_distribution == 'Debian' - ansible_distribution_release == 'stretch' template: - src: 'apt/sources.list.j2' - dest: '/etc/apt/sources.list' + src: apt/sources.list.j2 + dest: /etc/apt/sources.list mode: 0644 # Patriotisme diff --git a/roles/codimd/tasks/0_apt_dependencies.yml b/roles/codimd/tasks/0_apt_dependencies.yml index 0fcacfb..76646e6 100644 --- a/roles/codimd/tasks/0_apt_dependencies.yml +++ b/roles/codimd/tasks/0_apt_dependencies.yml @@ -18,7 +18,7 @@ - name: Configure Yarn repository apt_repository: - repo: "deb https://dl.yarnpkg.com/debian/ stable main" + repo: deb https://dl.yarnpkg.com/debian/ stable main # Install CodiMD dependencies - name: Install required packages diff --git a/roles/codimd/tasks/main.yml b/roles/codimd/tasks/main.yml index f3b349f..f176b95 100644 --- a/roles/codimd/tasks/main.yml +++ b/roles/codimd/tasks/main.yml @@ -47,8 +47,8 @@ # Service file - name: Install CodiMD systemd unit template: - src: 'systemd/codimd.service.j2' - dest: '/etc/systemd/system/codimd.service' + src: systemd/codimd.service.j2 + dest: /etc/systemd/system/codimd.service owner: root group: root mode: 0644 diff --git a/roles/ldap-client/handlers/main.yml b/roles/ldap-client/handlers/main.yml index b233281..f0f3111 100644 --- a/roles/ldap-client/handlers/main.yml +++ b/roles/ldap-client/handlers/main.yml @@ -1,6 +1,6 @@ --- - name: Reconfigure libnss-ldapd package - command: 'dpkg-reconfigure libnss-ldapd -f noninteractive' + command: dpkg-reconfigure libnss-ldapd -f noninteractive - name: Restart nslcd service service: diff --git a/roles/ldap-client/tasks/1_group_security.yml b/roles/ldap-client/tasks/1_group_security.yml index 9e01f03..d9bf2cb 100644 --- a/roles/ldap-client/tasks/1_group_security.yml +++ b/roles/ldap-client/tasks/1_group_security.yml @@ -3,8 +3,8 @@ - name: Filter SSH on groups lineinfile: dest: /etc/ssh/sshd_config - regexp: '^AllowGroups' - line: "AllowGroups root sudoldap aurore ssh" + regexp: ^AllowGroups + line: AllowGroups root sudoldap aurore ssh # To gain root access with ldap rights - name: Install SUDO package @@ -19,13 +19,13 @@ - name: Configure sudoers sudo group lineinfile: dest: /etc/sudoers - regexp: "^%{{ sudo_group }}" + regexp: ^%{{ sudo_group }} line: "%{{ sudo_group }} ALL=(ALL:ALL) ALL" # Set sudo location group - name: Configure sudoers sudo location group lineinfile: dest: /etc/sudoers - regexp: "^%{{ sudo_group_location }}" + regexp: ^%{{ sudo_group_location }} line: "%{{ sudo_group_location }} ALL=(ALL:ALL) ALL" when: sudo_group_location is defined diff --git a/roles/ldap-client/tasks/2_userland_scripts.yml b/roles/ldap-client/tasks/2_userland_scripts.yml index 34d0098..4799765 100644 --- a/roles/ldap-client/tasks/2_userland_scripts.yml +++ b/roles/ldap-client/tasks/2_userland_scripts.yml @@ -3,7 +3,7 @@ - name: Copy passwd and chsh scripts template: src: "{{ item }}.j2" - dest: "/usr/local/bin/{{ item }}" + dest: /usr/local/bin/{{ item }} mode: 0755 with_items: - chsh diff --git a/roles/ldap-replica/tasks/main.yml b/roles/ldap-replica/tasks/main.yml index 45f99c5..bb31e09 100644 --- a/roles/ldap-replica/tasks/main.yml +++ b/roles/ldap-replica/tasks/main.yml @@ -43,7 +43,7 @@ # Install schema as root # We can't do a `become_user` here - name: Install LDAP schema - command: 'slapadd -n 0 -l /etc/ldap/schema.ldiff -F /etc/ldap/slapd.d' + command: slapadd -n 0 -l /etc/ldap/schema.ldiff -F /etc/ldap/slapd.d # then fix permissions - name: Fix permissions @@ -53,8 +53,8 @@ group: openldap recurse: true with_items: - - '/var/lib/ldap' - - '/etc/ldap/slapd.d' + - /var/lib/ldap + - /etc/ldap/slapd.d # Save the day - name: Start LDAP server diff --git a/roles/matrix-appservice-discord/tasks/main.yml b/roles/matrix-appservice-discord/tasks/main.yml index f043ae3..d4f4cb5 100644 --- a/roles/matrix-appservice-discord/tasks/main.yml +++ b/roles/matrix-appservice-discord/tasks/main.yml @@ -44,8 +44,8 @@ # Service file - name: Install matrix-appservice-discord systemd unit template: - src: 'systemd/matrix-appservice-discord.service.j2' - dest: '/etc/systemd/system/matrix-appservice-discord.service' + src: systemd/matrix-appservice-discord.service.j2 + dest: /etc/systemd/system/matrix-appservice-discord.service owner: root group: root mode: 0644 diff --git a/roles/matrix-appservice-irc/tasks/main.yml b/roles/matrix-appservice-irc/tasks/main.yml index 54c8394..5db1c1b 100644 --- a/roles/matrix-appservice-irc/tasks/main.yml +++ b/roles/matrix-appservice-irc/tasks/main.yml @@ -33,8 +33,8 @@ # Service file - name: Install matrix-appservice-irc systemd unit template: - src: 'systemd/matrix-appservice-irc.service.j2' - dest: '/etc/systemd/system/matrix-appservice-irc.service' + src: systemd/matrix-appservice-irc.service.j2 + dest: /etc/systemd/system/matrix-appservice-irc.service owner: root group: root mode: 0644 diff --git a/roles/matrix-appservice-webhooks/tasks/main.yml b/roles/matrix-appservice-webhooks/tasks/main.yml index 7cf9e02..a0b9e43 100644 --- a/roles/matrix-appservice-webhooks/tasks/main.yml +++ b/roles/matrix-appservice-webhooks/tasks/main.yml @@ -33,8 +33,8 @@ # Service file - name: Install matrix-appservice-webhooks systemd unit template: - src: 'systemd/matrix-appservice-webhooks.service.j2' - dest: '/etc/systemd/system/matrix-appservice-webhooks.service' + src: systemd/matrix-appservice-webhooks.service.j2 + dest: /etc/systemd/system/matrix-appservice-webhooks.service owner: root group: root mode: 0644 diff --git a/roles/matrix-riot/tasks/main.yml b/roles/matrix-riot/tasks/main.yml index 04be56f..8b83ef1 100644 --- a/roles/matrix-riot/tasks/main.yml +++ b/roles/matrix-riot/tasks/main.yml @@ -11,7 +11,7 @@ # Add the repository into source list - name: Configure riot repository apt_repository: - repo: "deb https://riot.im/packages/debian/ {{ ansible_distribution_release }} main" + repo: deb https://riot.im/packages/debian/ {{ ansible_distribution_release }} main # Add the key - name: Configure the apt key diff --git a/roles/nginx-reverse-proxy/tasks/main.yml b/roles/nginx-reverse-proxy/tasks/main.yml index c646a23..a570a9f 100644 --- a/roles/nginx-reverse-proxy/tasks/main.yml +++ b/roles/nginx-reverse-proxy/tasks/main.yml @@ -13,8 +13,8 @@ # Install proxy snippets - name: Configure NGINX proxy snippets template: - src: "nginx/snippets/{{ item }}.j2" - dest: "/etc/nginx/snippets/{{ item }}" + src: nginx/snippets/{{ item }}.j2 + dest: /etc/nginx/snippets/{{ item }} mode: 0644 loop: - proxy-common.conf @@ -25,7 +25,7 @@ - name: Configure NGINX sites template: src: nginx/nginx-sites-available.j2 - dest: "/etc/nginx/sites-available/{{ item.name }}" + dest: /etc/nginx/sites-available/{{ item.name }} mode: 0644 loop: "{{ reversed_proxy_subdomains }}" notify: Reload NGINX service @@ -40,8 +40,8 @@ # Activate sites - name: Activate sites file: - src: "/etc/nginx/sites-available/{{ item.name }}" - dest: "/etc/nginx/sites-enabled/{{ item.name }}" + src: /etc/nginx/sites-available/{{ item.name }} + dest: /etc/nginx/sites-enabled/{{ item.name }} state: link loop: "{{ reversed_proxy_subdomains }}" notify: Reload NGINX service